platform/x86: asus-wmi: Fix regression when probing for fan curve control
authorHans de Goede <hdegoede@redhat.com>
Sat, 5 Feb 2022 11:28:40 +0000 (12:28 +0100)
committerHans de Goede <hdegoede@redhat.com>
Sat, 5 Feb 2022 13:43:01 +0000 (14:43 +0100)
The fan curve control patches introduced a regression for at least the
TUF FX506 and possibly other TUF series laptops that do not have support
for fan curve control.

As part of the probing process, asus_wmi_evaluate_method_buf is called
to get the factory default fan curve . The WMI management function
returns 0 on certain laptops to indicate lack of fan curve control
instead of ASUS_WMI_UNSUPPORTED_METHOD. This 0 is transformed to
-ENODATA which results in failure when probing.

Fixes: 0f0ac158d28f ("platform/x86: asus-wmi: Add support for custom fan curves")
Reported-and-tested-by: Abhijeet V <abhijeetviswa@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20220205112840.33095-1-hdegoede@redhat.com
drivers/platform/x86/asus-wmi.c

index a3b83b2..2104a26 100644 (file)
@@ -2223,7 +2223,7 @@ static int fan_curve_check_present(struct asus_wmi *asus, bool *available,
 
        err = fan_curve_get_factory_default(asus, fan_dev);
        if (err) {
-               if (err == -ENODEV)
+               if (err == -ENODEV || err == -ENODATA)
                        return 0;
                return err;
        }