media: ccs-pll: Add sanity checks
authorSakari Ailus <sakari.ailus@linux.intel.com>
Tue, 4 Aug 2020 10:58:30 +0000 (12:58 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 7 Dec 2020 14:58:01 +0000 (15:58 +0100)
Add sanity checks for fields that could cause division by zero.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/ccs-pll.c

index e3a6493..420d2c4 100644 (file)
@@ -421,6 +421,15 @@ int ccs_pll_calculate(struct device *dev, const struct ccs_pll_limits *lim,
                pll->vt_lanes = 1;
        }
 
+       if (!pll->op_lanes || !pll->vt_lanes || !pll->bits_per_pixel ||
+           !pll->ext_clk_freq_hz || !pll->link_freq || !pll->scale_m ||
+           !op_lim_fr->min_pll_ip_clk_freq_hz ||
+           !op_lim_fr->max_pll_ip_clk_freq_hz ||
+           !op_lim_fr->min_pll_op_clk_freq_hz ||
+           !op_lim_fr->max_pll_op_clk_freq_hz ||
+           !op_lim_bk->max_sys_clk_div || !op_lim_fr->max_pll_multiplier)
+               return -EINVAL;
+
        /*
         * Make sure op_pix_clk_div will be integer --- unless flexible
         * op_pix_clk_div is supported