Merge branch 'fix-pr9400' into maint
authorStefano Lattarini <stefano.lattarini@gmail.com>
Thu, 6 Oct 2011 19:40:17 +0000 (21:40 +0200)
committerStefano Lattarini <stefano.lattarini@gmail.com>
Thu, 6 Oct 2011 19:40:17 +0000 (21:40 +0200)
* fix-pr9400:
  parallel-tests: don't allow @substitutions@ in TEST_EXTENSIONS

1  2 
ChangeLog

diff --cc ChangeLog
+++ b/ChangeLog
@@@ -1,31 -1,21 +1,49 @@@
  2011-10-06  Stefano Lattarini  <stefano.lattarini@gmail.com>
  
+       parallel-tests: don't allow @substitutions@ in TEST_EXTENSIONS
+       Even after the last commit `v1.11-476-g90bea64', the checks
+       performed by automake on entries in $(TEST_EXTENSIONS) tried to
+       allow for @substitited@ stuff.  This however ends up allowing
+       quite brittle setups, which, most importantly, are of no real
+       practical usefulness anyway.  So it's better to just disallow
+       @substitutions@ in TEST_EXTENSIONS altogether, offering a clear
+       error message, instead of risking weird bugs and unexpected
+       behaviors in the generated Makefile.in.
+       * automake.in ($TEST_EXTENSION_PATTERN): Turned from a regular
+       expression ...
+       (is_valid_test_extension): ... into this subroutine.  Don't allow
+       generic @substitutions@ anymore (possibly making an exception for
+       `@EXEEXT@' under the proper circumstances).
+       * tests/test-extensions.test: Adjust and extend.
++2011-10-06  Stefano Lattarini  <stefano.lattarini@gmail.com>
++
 +      tests: fix spurious failure in 'insthook.test'
 +      * tests/insthook.test (Makefile.am): Add a proper `uninstall-hook'
 +      target to remove the symlink created by the `install-exec-hook'
 +      target; this prevents "make distcheck" from failing spuriously.
 +      Since we are at it, delete an extra blank line, and add a trailing
 +      `:' command.
 +
 +2011-10-06  Stefano Lattarini  <stefano.lattarini@gmail.com>
 +
 +      maintcheck: fix spurious failure
 +      * lib/am/distdir.am: Use `$(infodir)', not `${infodir}', to avoid
 +      complaints from the `sc_no_brace_variable_expansions' maintainer
 +      check.
 +
 +2011-10-06  Stefano Lattarini  <stefano.lattarini@gmail.com>
 +
 +      fix: make a test script executable
 +      * tests/nobase-nodist.test: Make executable.
 +
 +2011-10-06  Stefano Lattarini  <stefano.lattarini@gmail.com>
 +
 +      coverage: expose automake bug#9651
 +      * tests/dist-auxfile.test: New test, xfailing.
 +      * tests/dist-auxfile-2.test: Likewise.
 +      * tests/Makefile.am (TESTS, XFAIL_TESTS): Add them.
 +
  2011-10-01  Stefano Lattarini  <stefano.lattarini@gmail.com>
  
        parallel-tests: automake error our on invalid TEST_EXTENSIONS