Improve the libdlogutil coverage test

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b022

diff --git a/tests/dlog_coverage.in b/tests/dlog_coverage.in
index 597e385..9b42036 100644 (file)
--- a/tests/dlog_coverage.in
+++ b/tests/dlog_coverage.in
@@ -12,7 +12,7 @@
 @bindir@/tizen-unittests/dlog/test_capi_coverage
 
 for MODE in monitor priority_exact pid_wrong tid_wrong tag_wrong prefix_wrong sorting clear alias negative; do
-       @bindir@/tizen-unittests/dlog/test_libdlogutil_cov $MODE 123 pipe
+       @bindir@/tizen-unittests/dlog/test_libdlogutil_cov $MODE 0 pipe
 done
 
 dlogsend -b main -b radio -b apps -b dotnet -b dotnet_api -b native -b native_api bla

diff --git a/tests/test_libdlogutil.c b/tests/test_libdlogutil.c
index 9616505..d4238d6 100644 (file)
--- a/tests/test_libdlogutil.c
+++ b/tests/test_libdlogutil.c
@@ -106,7 +106,7 @@ const char *mode_desc[] = {
 void print_usage_and_die(const char *name)
 {
        fprintf(stderr, "Usage: %s TEST PID TYPE\n"
-               "where PID is the process id of the logging process,\n"
+               "where PID is the process id of the logging process (or 0),\n"
                "TYPE is \"pipe\" or \"logger\" depending on the backend used,\n"
                "and TEST chooses a test and is one of the following:\n", name);
 
@@ -222,7 +222,8 @@ void get_logs_main(enum test_mode mode, backend_t backend, pid_t pid)
                        r = dlogutil_entry_get_message(e, &msg);
                        assert(r == 0);
 
-                       assert(!strcmp(tag, "SRPOL_LOGGER"));
+                       // !pid also means we are fine looking at random logs
+                       assert(!pid || !strcmp(tag, "SRPOL_LOGGER"));
 
                        pid_t apid, atid;
                        r = dlogutil_entry_get_pid(e, &apid);
@@ -230,8 +231,8 @@ void get_logs_main(enum test_mode mode, backend_t backend, pid_t pid)
                        r = dlogutil_entry_get_tid(e, &atid);
                        assert(r == 0);
 
-                       assert(pid == apid);
-                       assert(pid == atid);
+                       assert(!pid || pid == apid);
+                       assert(!pid || pid == atid);
 
                        switch (prio) {
                                case DLOG_ERROR: