udpsrc: don't crash dereferencing NULL error when leaving multicast group on shutdown
authorTim-Philipp Müller <tim.muller@collabora.co.uk>
Tue, 24 Jul 2012 18:04:39 +0000 (19:04 +0100)
committerTim-Philipp Müller <tim.muller@collabora.co.uk>
Tue, 24 Jul 2012 19:06:07 +0000 (20:06 +0100)
Strangely enough, if we do pass an error variable to be filled, we
no longer get an error on leaving.

gst/udp/gstudpsrc.c

index 1f42b8f..0440f47 100644 (file)
@@ -954,7 +954,7 @@ gst_udpsrc_stop (GstBaseSrc * bsrc)
 
       if (!g_socket_leave_multicast_group (src->used_socket,
               g_inet_socket_address_get_address (src->addr), FALSE,
-              src->multi_iface, NULL)) {
+              src->multi_iface, &err)) {
         GST_ERROR_OBJECT (src, "Failed to leave multicast group: %s",
             err->message);
         g_clear_error (&err);