Fix coverity issue (RESOURCE_LEAK) 14/307114/2 accepted/tizen/unified/20240306.094106 accepted/tizen/unified/toolchain/20240311.065438 accepted/tizen/unified/x/20240307.010814
authorJiyong <jiyong.min@samsung.com>
Tue, 5 Mar 2024 04:29:04 +0000 (13:29 +0900)
committerJiyong <jiyong.min@samsung.com>
Tue, 5 Mar 2024 04:34:28 +0000 (13:34 +0900)
- Variable '_module' leaks the storage when 'module' is null

Change-Id: I7ddc9e1c70a0fedddf417fc823bd4a021955237c

imgp/mm_util_imgp.c
packaging/libmm-utility.spec

index fc3f9b0..4456655 100644 (file)
@@ -279,8 +279,10 @@ static IMGPInfoFunc __mm_util_initialize(void **module)
        void *_module = NULL;
        IMGPInfoFunc _func = NULL;
 
+       mm_util_retvm_if(!module, NULL, "invalid module");
+
        _module = dlopen(PATH_GSTCS_LIB, RTLD_LAZY);
-       mm_util_retvm_if(!module, NULL, "%s module open failed", PATH_GSTCS_LIB);
+       mm_util_retvm_if(!_module, NULL, "%s module open failed", PATH_GSTCS_LIB);
 
        _func = dlsym(_module, IMGP_FUNC_NAME);
        if (!_func) {
index ae6db70..7d9b07b 100644 (file)
@@ -1,6 +1,6 @@
 Name:       libmm-utility
 Summary:    Multimedia Framework Utility Library
-Version:    0.4.17
+Version:    0.4.18
 Release:    0
 Group:      System/Libraries
 License:    Apache-2.0