gl: guard against using a NULL window pointer
authorVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Mon, 21 Apr 2014 08:50:19 +0000 (09:50 +0100)
committerTim-Philipp Müller <tim@centricular.com>
Sat, 9 Dec 2017 19:31:37 +0000 (19:31 +0000)
Coverity 1195145

ext/gl/gstglimagesink.c

index 4626e83..2d0ed97 100644 (file)
@@ -1198,8 +1198,10 @@ gst_glimage_sink_redisplay (GstGLImageSink * gl_sink)
   gboolean alive;
 
   window = gst_gl_context_get_window (gl_sink->context);
+  if (!window)
+    return FALSE;
 
-  if (window && gst_gl_window_is_running (window)) {
+  if (gst_gl_window_is_running (window)) {
 
 #if GST_GL_HAVE_GLES2
     if (USING_GLES2 (gl_sink->context)) {