ext/xvid/gstxvidenc.*: Remove superfluous 'frame-encoded' signal (people can use...

Original commit message from CVS:
* ext/xvid/gstxvidenc.c:
* ext/xvid/gstxvidenc.h:
Remove superfluous 'frame-encoded' signal (people can
use an upstream identity's 'handoff' signal or a pad
probe for this if they must know).

diff --git a/ChangeLog b/ChangeLog
index 9b207e7..46e852e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2007-09-27  Tim-Philipp Müller  <tim at centricular dot net>
+
+       * ext/xvid/gstxvidenc.c:
+       * ext/xvid/gstxvidenc.h:
+         Remove superfluous 'frame-encoded' signal (people can
+         use an upstream identity's 'handoff' signal or a pad
+         probe for this if they must know).
+
 2007-09-27  Julien MOUTTE  <julien@moutte.net>
 
        * gst/flv/gstflvparse.c: (gst_flv_parse_tag_audio),

diff --git a/ext/xvid/gstxvidenc.c b/ext/xvid/gstxvidenc.c
index 7b77deb..17aae98 100644 (file)
--- a/ext/xvid/gstxvidenc.c
+++ b/ext/xvid/gstxvidenc.c
@@ -64,12 +64,7 @@ static GstStaticPadTemplate src_template = GST_STATIC_PAD_TEMPLATE ("src",
     );
 
 
-/* XvidEnc signals and properties */
-enum
-{
-  FRAME_ENCODED,
-  LAST_SIGNAL
-};
+/* XvidEnc properties */
 
 /* maximum property-id */
 static int xvidenc_prop_count;
@@ -98,7 +93,6 @@ static GstStateChangeReturn gst_xvidenc_change_state (GstElement * element,
     GstStateChange transition);
 
 static GstElementClass *parent_class = NULL;
-static guint gst_xvidenc_signals[LAST_SIGNAL] = { 0 };
 
 #define GST_TYPE_XVIDENC_PROFILE (gst_xvidenc_profile_get_type ())
 static GType
@@ -457,13 +451,6 @@ gst_xvidenc_class_init (GstXvidEncClass * klass)
       G_PARAM_READWRITE);
   gst_xvidenc_add_pspec (gobject_class, pspec, container_frame_overhead);
 
-  /* signals */
-  gst_xvidenc_signals[FRAME_ENCODED] =
-      g_signal_new ("frame-encoded", G_TYPE_FROM_CLASS (klass),
-      G_SIGNAL_RUN_LAST,
-      G_STRUCT_OFFSET (GstXvidEncClass, frame_encoded),
-      NULL, NULL, g_cclosure_marshal_VOID__VOID, G_TYPE_NONE, 0);
-
   gstelement_class->change_state = GST_DEBUG_FUNCPTR (gst_xvidenc_change_state);
 }
 
@@ -962,9 +949,6 @@ gst_xvidenc_chain (GstPad * pad, GstBuffer * buf)
   if (!outbuf)                  /* error or no data yet */
     return GST_FLOW_OK;
 
-  /* proclaim destiny */
-  g_signal_emit (G_OBJECT (xvidenc), gst_xvidenc_signals[FRAME_ENCODED], 0);
-
   /* go out, multiply! */
   return gst_pad_push (xvidenc->srcpad, outbuf);
 }

diff --git a/ext/xvid/gstxvidenc.h b/ext/xvid/gstxvidenc.h
index 963c16a..a2f32d0 100644 (file)
--- a/ext/xvid/gstxvidenc.h
+++ b/ext/xvid/gstxvidenc.h
@@ -127,9 +127,6 @@ struct _GstXvidEnc {
 
 struct _GstXvidEncClass {
   GstElementClass parent_class;
-
-  /* signals */
-  void (*frame_encoded) (GstElement *element);
 };
 
 GType gst_xvidenc_get_type(void);