libs: encoder: h264fei: remove unnecessary check

Issue detected by Coverity

There may be a null pointer dereference, or else the comparison
against null is unnecessary.

In gst_vaapi_encoder_h264_fei_encode: All paths that lead to this null
pointer comparison already dereference the pointer earlier

diff --git a/gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c b/gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c
index e0fbe5054dfa55bafaa68225658ac499b8f8a22a..d643a6a67da40b6f879a5aef1fc3645421ca37ad 100644 (file)
--- a/gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c
+++ b/gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c
@@ -2837,9 +2837,8 @@ gst_vaapi_encoder_h264_fei_encode (GstVaapiEncoder * base_encoder,
   /* ERRORS */
 error:
   {
-    if (reconstruct)
-      gst_vaapi_encoder_release_surface (GST_VAAPI_ENCODER (encoder),
-          reconstruct);
+    gst_vaapi_encoder_release_surface (GST_VAAPI_ENCODER (encoder),
+        reconstruct);
     if (picture2)
       gst_vaapi_enc_picture_unref (picture2);
     return status;