Fix coverity error in shader-generator 06/311406/1
authorAdeel Kazmi <adeel.kazmi@samsung.com>
Mon, 20 May 2024 16:08:17 +0000 (17:08 +0100)
committerAdeel Kazmi <adeel.kazmi@samsung.com>
Mon, 20 May 2024 16:08:31 +0000 (17:08 +0100)
Change-Id: Iebff30df062f13b2ef263a10c53c0f393d9d3545

dali-toolkit/shader-generator/shader-generator.cpp

index b841598..230fafb 100644 (file)
@@ -304,19 +304,13 @@ int GenerateShaderSources(fs::path inDir, fs::path outDir, const bool generateBu
           if(shaderFile.is_open())
           {
             fs::path outFilePath(GetShaderOutputFilePath(outDir, filename));
-            generator.Add(std::move(shaderVariableName), outFilePath.filename().string());
-            if(fs::exists(outFilePath))
+            // If output file already exists, then only overwrite if input file is newer than output file
+            if(!fs::exists(outFilePath) || (fs::last_write_time(path) > fs::last_write_time(outFilePath)))
             {
-              // Only overwrite if input file is newer than output file
-              fs::file_time_type inFileTime = fs::last_write_time(path);
-              fs::file_time_type outFileTime = fs::last_write_time(outFilePath);
-              if(outFileTime > inFileTime)
-              {
-                continue;
-              }
+              GenerateHeaderFile(shaderFile, shaderVariableName, outFilePath);
+              shaderGenerated = true;
             }
-            GenerateHeaderFile(shaderFile, shaderVariableName, outFilePath);
-            shaderGenerated = true;
+            generator.Add(std::move(shaderVariableName), outFilePath.filename().string());
           }
           break;
         }