projects
/
platform
/
upstream
/
dotnet
/
runtime.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6a855af
)
RyuJIT x86: Fix initblk with unrolled loop and constant fill
author
Bruce Forstall
<brucefo@microsoft.com>
Sat, 27 Aug 2016 01:25:42 +0000
(18:25 -0700)
committer
Bruce Forstall
<brucefo@microsoft.com>
Sat, 27 Aug 2016 01:25:42 +0000
(18:25 -0700)
The computed fill value was only using the low 8 bytes of the
xmm register; we need it to fill the entire 16 byte register.
Fixes dotnet/coreclr#6940
Commit migrated from https://github.com/dotnet/coreclr/commit/
5127eef602e0c0ed5ab7f63a9bc28b81558b2084
src/coreclr/src/jit/codegenxarch.cpp
patch
|
blob
|
history
diff --git
a/src/coreclr/src/jit/codegenxarch.cpp
b/src/coreclr/src/jit/codegenxarch.cpp
index
5e35067
..
e616305
100755
(executable)
--- a/
src/coreclr/src/jit/codegenxarch.cpp
+++ b/
src/coreclr/src/jit/codegenxarch.cpp
@@
-3489,8
+3489,12
@@
void CodeGen::genCodeForInitBlkUnroll(GenTreeInitBlk* initBlkNode)
if (initVal->gtIntCon.gtIconVal != 0)
{
- emit->emitIns_R_R(INS_mov_i2xmm, EA_
8BYT
E, tmpReg, valReg);
+ emit->emitIns_R_R(INS_mov_i2xmm, EA_
PTRSIZ
E, tmpReg, valReg);
emit->emitIns_R_R(INS_punpckldq, EA_8BYTE, tmpReg, tmpReg);
+#ifdef _TARGET_X86_
+ // For x86, we need one more to convert it from 8 bytes to 16 bytes.
+ emit->emitIns_R_R(INS_punpckldq, EA_8BYTE, tmpReg, tmpReg);
+#endif // _TARGET_X86_
}
else
{