st/texture: allow compute blits for (some) non-finalized textures
authorMike Blumenkrantz <michael.blumenkrantz@gmail.com>
Fri, 13 May 2022 19:29:24 +0000 (15:29 -0400)
committerMarge Bot <emma+marge@anholt.net>
Wed, 1 Jun 2022 02:50:32 +0000 (02:50 +0000)
this yields sizable perf improvements in some cases

KHR-GL46.copy_image.functional timing (zink+anv-icl):

before
MESA_LOADER_DRIVER_OVERRIDE=zink ./glcts -n   74.77s user 76.44s system 33% cpu 7:32.38 total

after
MESA_LOADER_DRIVER_OVERRIDE=zink ./glcts -n   69.95s user 68.84s system 33% cpu 6:51.54 total

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16545>

src/mesa/state_tracker/st_cb_texture.c

index f36800f..485a056 100644 (file)
@@ -2435,8 +2435,11 @@ st_GetTexSubImage(struct gl_context * ctx,
       goto non_blit_transfer;
    }
 
+   if (stImage->pt != stObj->pt)
+      goto non_blit_transfer;
+
    /* Handle non-finalized textures. */
-   if (!stImage->pt || stImage->pt != stObj->pt || !src) {
+   if (!stImage->pt || !src) {
       goto cpu_transfer;
    }