thunderbolt: Find XDomain by route instead of UUID
authorMika Westerberg <mika.westerberg@linux.intel.com>
Wed, 7 Oct 2020 14:01:43 +0000 (17:01 +0300)
committerMika Westerberg <mika.westerberg@linux.intel.com>
Wed, 11 Nov 2020 07:20:16 +0000 (10:20 +0300)
We are going to represent loops back to the host also as XDomains and
they all have the same (host) UUID, so finding them needs to use route
string instead. This also requires that we check if the XDomain device
is added to the bus before its properties can be updated. Otherwise the
remote UUID might not be populated yet.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Yehezkel Bernat <YehezkelShB@gmail.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/thunderbolt/xdomain.c

index 4890785..e436e9e 100644 (file)
@@ -587,8 +587,6 @@ static void tb_xdp_handle_request(struct work_struct *work)
                break;
 
        case PROPERTIES_CHANGED_REQUEST: {
-               const struct tb_xdp_properties_changed *xchg =
-                       (const struct tb_xdp_properties_changed *)pkg;
                struct tb_xdomain *xd;
 
                ret = tb_xdp_properties_changed_response(ctl, route, sequence);
@@ -598,10 +596,12 @@ static void tb_xdp_handle_request(struct work_struct *work)
                 * the xdomain related to this connection as well in
                 * case there is a change in services it offers.
                 */
-               xd = tb_xdomain_find_by_uuid_locked(tb, &xchg->src_uuid);
+               xd = tb_xdomain_find_by_route_locked(tb, route);
                if (xd) {
-                       queue_delayed_work(tb->wq, &xd->get_properties_work,
-                                          msecs_to_jiffies(50));
+                       if (device_is_registered(&xd->dev)) {
+                               queue_delayed_work(tb->wq, &xd->get_properties_work,
+                                                  msecs_to_jiffies(50));
+                       }
                        tb_xdomain_put(xd);
                }