drm/tegra: Run hub cleanup on ->remove()
authorThierry Reding <treding@nvidia.com>
Tue, 3 Dec 2019 16:19:14 +0000 (17:19 +0100)
committerThierry Reding <treding@nvidia.com>
Wed, 4 Dec 2019 12:38:16 +0000 (13:38 +0100)
The call to tegra_display_hub_cleanup() that takes care of disabling the
window groups is missing from the driver's ->remove() callback. Call it
to make sure the runtime PM reference counts for the display controllers
are balanced.

Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/gpu/drm/tegra/drm.c

index 7a16b51eaa2da8285c341d2c83c5e8e0ad771dda..f455ce71e85d9c6bff84388815caa87f9a22409b 100644 (file)
@@ -1241,6 +1241,9 @@ static int host1x_drm_remove(struct host1x_device *dev)
        drm_atomic_helper_shutdown(drm);
        drm_mode_config_cleanup(drm);
 
+       if (tegra->hub)
+               tegra_display_hub_cleanup(tegra->hub);
+
        err = host1x_device_exit(dev);
        if (err < 0)
                dev_err(&dev->dev, "host1x device cleanup failed: %d\n", err);