Change char unique_ptr to char vector 99/62999/1 accepted/tizen/common/20160322.150131 accepted/tizen/ivi/20160323.011052 accepted/tizen/mobile/20160323.011000 accepted/tizen/tv/20160323.011015 accepted/tizen/wearable/20160323.011033 submit/tizen/20160322.014817
authorKyungwook Tak <k.tak@samsung.com>
Mon, 21 Mar 2016 11:55:45 +0000 (20:55 +0900)
committerKyungwook Tak <k.tak@samsung.com>
Mon, 21 Mar 2016 11:55:45 +0000 (20:55 +0900)
char vector can free resource naturally than unique_ptr
which should use delete [] explicitly by destructor.

Related SVACE defect id : 56526, 56527

Vericiation: ckm-tests-internal --run_test=ENCRYPTION_SCHEME_TEST

Change-Id: I508192c49557b9f980556e7a20d589be37390b3b
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
tests/encryption-scheme/scheme-test.cpp

index abb6538..47d1569 100644 (file)
@@ -32,6 +32,7 @@
 
 #include <fstream>
 #include <stdexcept>
+#include <vector>
 
 #include <boost/test/unit_test.hpp>
 
@@ -263,10 +264,9 @@ uid_t getUid(const char *name) {
 
     memset(&pwd, 0x00, sizeof(pwd));
 
-    std::unique_ptr<char> buf(new char[bufsize]);
-    BOOST_REQUIRE_MESSAGE(buf, "failed to allocate mem for buf for getpwname_r");
+    std::vector<char> buf(bufsize, 0);
 
-    int ret = getpwnam_r(name, &pwd, buf.get(), bufsize, &result);
+    int ret = getpwnam_r(name, &pwd, buf.data(), bufsize, &result);
     BOOST_REQUIRE_MESSAGE(ret == 0 && result, "getpwnam_r failed");
 
     return pwd.pw_uid;
@@ -281,10 +281,9 @@ gid_t getGid(const char *name) {
 
     memset(&grp, 0x00, sizeof(grp));
 
-    std::unique_ptr<char> buf(new char[bufsize]);
-    BOOST_REQUIRE_MESSAGE(buf, "failed to allocate mem for buf for getgrnam_r");
+    std::vector<char> buf(bufsize, 0);
 
-    int ret = getgrnam_r(name, &grp, buf.get(), bufsize, &result);
+    int ret = getgrnam_r(name, &grp, buf.data(), bufsize, &result);
     BOOST_REQUIRE_MESSAGE(ret == 0 && result, "getgrnam_r failed");
 
     return grp.gr_gid;