block: make blk_iopoll_prep_sched() follow normal 0/1 return convention
authorJens Axboe <jens.axboe@oracle.com>
Tue, 11 Aug 2009 06:31:14 +0000 (08:31 +0200)
committerJens Axboe <jens.axboe@oracle.com>
Fri, 11 Sep 2009 12:33:32 +0000 (14:33 +0200)
Return 0 if we successfully marked this iopoll structure as ours for
scheduling, instead of 1.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
include/linux/blk-iopoll.h

index b2e1739..308734d 100644 (file)
@@ -18,10 +18,17 @@ enum {
        IOPOLL_F_DISABLE        = 1,
 };
 
+/*
+ * Returns 0 if we successfully set the IOPOLL_F_SCHED bit, indicating
+ * that we were the first to acquire this iop for scheduling. If this iop
+ * is currently disabled, return "failure".
+ */
 static inline int blk_iopoll_sched_prep(struct blk_iopoll *iop)
 {
-       return !test_bit(IOPOLL_F_DISABLE, &iop->state) &&
-               !test_and_set_bit(IOPOLL_F_SCHED, &iop->state);
+       if (!test_bit(IOPOLL_F_DISABLE, &iop->state))
+               return test_and_set_bit(IOPOLL_F_SCHED, &iop->state);
+
+       return 1;
 }
 
 static inline int blk_iopoll_disable_pending(struct blk_iopoll *iop)