staging: vt6656: revert : 64 bit- Correctly address void structure.
authorMalcolm Priestley <tvboxspy@gmail.com>
Tue, 22 Jan 2013 20:12:34 +0000 (20:12 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Jan 2013 19:21:26 +0000 (11:21 -0800)
The patch is wrong and is partially reverted.

The NULL check of pTransmitKey->pvKeyTable is kept.

The problem was ultimately fixed by upstream commit.
1ee4c55fc9620451b2a825d793042a7e0775391b
staging: vt6656: Fix inconsistent structure packing

Reported-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Cc: stable@vger.kernel.org # 3.8
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6656/rxtx.c

index 536d314..92343f2 100644 (file)
@@ -1232,7 +1232,7 @@ static int s_bPacketToWirelessUsb(struct vnt_private *pDevice, u8 byPktType,
        pvRrvTime = pMICHDR = pvRTS = pvCTS = pvTxDataHd = NULL;
 
        if (bNeedEncryption && pTransmitKey->pvKeyTable) {
-               if (((PSKeyTable)&pTransmitKey->pvKeyTable)->bSoftWEP == TRUE)
+               if (((PSKeyTable)pTransmitKey->pvKeyTable)->bSoftWEP == TRUE)
                        bSoftWEP = TRUE; /* WEP 256 */
        }