drm/panel: sofef00: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210916104635.11675-1-caihuoqing@baidu.com

diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/drm/panel/panel-samsung-sofef00.c
index 6d107e1..1fb37fd 100644 (file)
--- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c
+++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c
@@ -270,18 +270,14 @@ static int sofef00_panel_probe(struct mipi_dsi_device *dsi)
        }
 
        ctx->supply = devm_regulator_get(dev, "vddio");
-       if (IS_ERR(ctx->supply)) {
-               ret = PTR_ERR(ctx->supply);
-               dev_err(dev, "Failed to get vddio regulator: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(ctx->supply))
+               return dev_err_probe(dev, PTR_ERR(ctx->supply),
+                                    "Failed to get vddio regulator\n");
 
        ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
-       if (IS_ERR(ctx->reset_gpio)) {
-               ret = PTR_ERR(ctx->reset_gpio);
-               dev_warn(dev, "Failed to get reset-gpios: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(ctx->reset_gpio))
+               return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio),
+                                    "Failed to get reset-gpios\n");
 
        ctx->dsi = dsi;
        mipi_dsi_set_drvdata(dsi, ctx);