platform/chrome: cros_ec_typec: Cleanup switch handle return paths
authorPrashant Malani <pmalani@chromium.org>
Tue, 16 Aug 2022 21:48:34 +0000 (21:48 +0000)
committerPrashant Malani <pmalani@chromium.org>
Thu, 18 Aug 2022 22:20:36 +0000 (22:20 +0000)
Some of the return paths for the cros_typec_get_switch_handles()
aren't necessary. Clean up the return paths to only undo the handle
get's which succeeded.

Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20220816214857.2088914-7-pmalani@chromium.org
drivers/platform/chrome/cros_ec_typec.c

index de6ee0f..ee54add 100644 (file)
@@ -158,12 +158,10 @@ static int cros_typec_get_switch_handles(struct cros_typec_port *port,
        return 0;
 
 role_sw_err:
-       usb_role_switch_put(port->role_sw);
-ori_sw_err:
        typec_switch_put(port->ori_sw);
-mux_err:
+ori_sw_err:
        typec_mux_put(port->mux);
-
+mux_err:
        return -ENODEV;
 }