mtd: core: Fix refcounting for unpartitioned MTDs
authorRichard Weinberger <richard@nod.at>
Sun, 6 Dec 2020 20:22:20 +0000 (21:22 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:54:23 +0000 (11:54 +0100)
commit 1ca71415f075353974524e96ed175306d8a937a8 upstream.

Apply changes to usecount also to the master partition.
Otherwise we have no refcounting at all if an MTD has no partitions.

Cc: stable@vger.kernel.org
Fixes: 46b5889cc2c5 ("mtd: implement proper partition handling")
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20201206202220.27290-1-richard@nod.at
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mtd/mtdcore.c

index e9e163a..b07cbb0 100644 (file)
@@ -993,6 +993,8 @@ int __get_mtd_device(struct mtd_info *mtd)
                }
        }
 
+       master->usecount++;
+
        while (mtd->parent) {
                mtd->usecount++;
                mtd = mtd->parent;
@@ -1059,6 +1061,8 @@ void __put_mtd_device(struct mtd_info *mtd)
                mtd = mtd->parent;
        }
 
+       master->usecount--;
+
        if (master->_put_device)
                master->_put_device(master);