[libc] Remove integration test target from check libc.
authorPaula Toth <paulatoth@google.com>
Tue, 2 Jun 2020 20:25:03 +0000 (13:25 -0700)
committerPaula Toth <paulatoth@google.com>
Tue, 2 Jun 2020 20:32:21 +0000 (13:32 -0700)
Summary:
This is failing on the asan build because we use `-nostdlib`.
I also took this opportunity to make the target name match the naming structure we've been using.

Reviewers: sivachandra

Reviewed By: sivachandra

Subscribers: mgorny, tschuett, ecnelises, libc-commits

Tags: #libc-project

Differential Revision: https://reviews.llvm.org/D81029

libc/test/src/CMakeLists.txt

index 561a129..c6bcdae 100644 (file)
@@ -38,32 +38,32 @@ add_custom_command(
 )
 
 add_executable(
-  public_integration_test
+  libc-integration-test
   EXCLUDE_FROM_ALL
   ${public_test}
 )
 # Blank out default include directories to prevent accidentally including
 # system headers or our own internal headers.
 set_target_properties(
-  public_integration_test
+  libc-integration-test
   PROPERTIES
   INCLUDE_DIRECTORIES ""
 )
 # Only include we need is the include for cpp::IsSame and our generated
 # public headers.
 target_include_directories(
-  public_integration_test BEFORE
+  libc-integration-test BEFORE
   PRIVATE
     "${LIBC_SOURCE_DIR}/utils/CPP"
     "${LIBC_BUILD_DIR}/include"
 )
 target_compile_options(
-  public_integration_test
+  libc-integration-test
   PRIVATE
   -ffreestanding
 )
 target_link_options(
-  public_integration_test
+  libc-integration-test
   PRIVATE "-nostdlib"
 )
 set(library_files)
@@ -74,7 +74,7 @@ endforeach()
 
 if(COMPILER_RESOURCE_DIR AND LLVM_LIBC_ENABLE_LINTING)
   add_custom_target(
-    public_integration_test-tidy
+    libc-integration-test-tidy
     VERBATIM
     COMMAND $<TARGET_FILE:clang-tidy> --system-headers
       --checks=-*,llvmlibc-restrict-system-libc-headers
@@ -88,11 +88,10 @@ if(COMPILER_RESOURCE_DIR AND LLVM_LIBC_ENABLE_LINTING)
     DEPENDS
       clang-tidy ${public_test}
   )
-  add_dependencies(check-libc public_integration_test-tidy)
+  add_dependencies(libc-integration-test libc-integration-test-tidy)
 endif()
 
-target_link_libraries(public_integration_test
+target_link_libraries(libc-integration-test
   PRIVATE
   ${library_files}
 )
-add_dependencies(check-libc public_integration_test)