lib: rename some power well bit names
authorPaulo Zanoni <paulo.r.zanoni@intel.com>
Tue, 3 Dec 2013 18:44:08 +0000 (16:44 -0200)
committerPaulo Zanoni <paulo.r.zanoni@intel.com>
Fri, 6 Dec 2013 15:10:36 +0000 (13:10 -0200)
I did the same change in the Kernel a few months ago. This should help
not getting confused about which bit does what.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
lib/intel_reg.h
tools/intel_reg_dumper.c

index 1c16e92..d8eec65 100644 (file)
@@ -3627,8 +3627,8 @@ typedef enum {
 #define HSW_PWR_WELL_CTL2                      0x45404         /* Driver */
 #define HSW_PWR_WELL_CTL3                      0x45408         /* KVMR */
 #define HSW_PWR_WELL_CTL4                      0x4540C         /* Debug */
-#define   HSW_PWR_WELL_ENABLE                  (1<<31)
-#define   HSW_PWR_WELL_STATE                   (1<<30)
+#define   HSW_PWR_WELL_ENABLE_REQUEST          (1<<31)
+#define   HSW_PWR_WELL_STATE_ENABLED           (1<<30)
 #define HSW_PWR_WELL_CTL5                      0x45410
 #define   HSW_PWR_WELL_ENABLE_SINGLE_STEP      (1<<31)
 #define   HSW_PWR_WELL_PWR_GATE_OVERRIDE       (1<<20)
index de518f5..6064695 100644 (file)
@@ -2857,12 +2857,12 @@ static uint32_t power_well_get(void)
        if (!IS_HASWELL(devid))
                return 0;
 
-       ret = INREG(HSW_PWR_WELL_CTL4) & HSW_PWR_WELL_ENABLE;
+       ret = INREG(HSW_PWR_WELL_CTL4) & HSW_PWR_WELL_ENABLE_REQUEST;
 
-       OUTREG(HSW_PWR_WELL_CTL4, HSW_PWR_WELL_ENABLE);
+       OUTREG(HSW_PWR_WELL_CTL4, HSW_PWR_WELL_ENABLE_REQUEST);
 
        for (i = 0; i < 20; i++) {
-               if (INREG(HSW_PWR_WELL_CTL4) & HSW_PWR_WELL_STATE)
+               if (INREG(HSW_PWR_WELL_CTL4) & HSW_PWR_WELL_STATE_ENABLED)
                        break;
                usleep(1000);
        }