V4L/DVB: cx231xx: cleanup dvb_attach() return value handling
authorMárton Németh <nm127@freemail.hu>
Sat, 16 Jan 2010 16:21:59 +0000 (13:21 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 26 Feb 2010 18:10:46 +0000 (15:10 -0300)
Remove the following sparse error (see "make C=1"):
 * error: incompatible types for operation (<)
       left side has type struct dvb_frontend *
       right side has type int

Signed-off-by: Márton Németh <nm127@freemail.hu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/cx231xx/cx231xx-dvb.c

index c5082a4..64e025e 100644 (file)
@@ -464,9 +464,9 @@ static int dvb_init(struct cx231xx *dev)
                /* define general-purpose callback pointer */
                dvb->frontend->callback = cx231xx_tuner_callback;
 
-               if (dvb_attach(xc5000_attach, dev->dvb->frontend,
+               if (!dvb_attach(xc5000_attach, dev->dvb->frontend,
                               &dev->i2c_bus[1].i2c_adap,
-                              &cnxt_rde250_tunerconfig) < 0) {
+                              &cnxt_rde250_tunerconfig)) {
                        result = -EINVAL;
                        goto out_free;
                }
@@ -486,9 +486,9 @@ static int dvb_init(struct cx231xx *dev)
                /* define general-purpose callback pointer */
                dvb->frontend->callback = cx231xx_tuner_callback;
 
-               if (dvb_attach(xc5000_attach, dev->dvb->frontend,
+               if (!dvb_attach(xc5000_attach, dev->dvb->frontend,
                               &dev->i2c_bus[1].i2c_adap,
-                              &cnxt_rde250_tunerconfig) < 0) {
+                              &cnxt_rde250_tunerconfig)) {
                        result = -EINVAL;
                        goto out_free;
                }