efi_loader: Pass address to fs_read()
authorAlexander Graf <agraf@suse.de>
Wed, 8 Aug 2018 09:54:32 +0000 (03:54 -0600)
committerAlexander Graf <agraf@suse.de>
Sun, 23 Sep 2018 19:55:28 +0000 (21:55 +0200)
The fs_read() function wants to get an address rather than the
pointer to a buffer.

So let's convert the passed buffer from pointer back a the address
to make efi_loader on sandbox happier.

Signed-off-by: Alexander Graf <agraf@suse.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Alexander Graf <agraf@suse.de>
lib/efi_loader/efi_file.c

index e6a15bc..2107730 100644 (file)
@@ -9,6 +9,7 @@
 #include <charset.h>
 #include <efi_loader.h>
 #include <malloc.h>
+#include <mapmem.h>
 #include <fs.h>
 
 /* GUID for file system information */
@@ -232,8 +233,10 @@ static efi_status_t file_read(struct file_handle *fh, u64 *buffer_size,
                void *buffer)
 {
        loff_t actread;
+       /* fs_read expects buffer address, not pointer */
+       uintptr_t buffer_addr = (uintptr_t)map_to_sysmem(buffer);
 
-       if (fs_read(fh->path, (ulong)buffer, fh->offset,
+       if (fs_read(fh->path, buffer_addr, fh->offset,
                    *buffer_size, &actread))
                return EFI_DEVICE_ERROR;