pvr: Do not require TA_STATE_HEADER.pres_ispctl_dbsc for {db,sc}enable
authorMatt Coster <matt.coster@imgtec.com>
Mon, 14 Aug 2023 08:26:20 +0000 (09:26 +0100)
committerMarge Bot <emma+marge@anholt.net>
Wed, 30 Aug 2023 14:30:15 +0000 (14:30 +0000)
This was a faulty assumption and caused valid control streams to report
as invalid.

Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Reviewed-by: Luigi Santivetti <luigi.santivetti@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24692>

src/imagination/vulkan/pvr_dump_csb.c

index b723fa9..fd8fbd7 100644 (file)
@@ -1263,8 +1263,7 @@ print_block_ppp_state_isp(struct pvr_dump_csb_ctx *const csb_ctx,
    pvr_dump_field_member_u32(base_ctx, &isp_ctl, validid);
 
    if (!has_fa || has_fb != isp_ctl.bpres || has_ba != isp_ctl.two_sided ||
-       has_bb != (isp_ctl.bpres && isp_ctl.two_sided) ||
-       has_dbsc != (isp_ctl.dbenable || isp_ctl.scenable)) {
+       has_bb != (isp_ctl.bpres && isp_ctl.two_sided)) {
       pvr_dump_error(
          base_ctx,
          "words declared by ppp header do not match requirements of ispctl word");