ptp: Pass hwtstamp to ptp_convert_timestamp()
authorGerhard Engleder <gerhard@engleder-embedded.com>
Fri, 6 May 2022 20:01:39 +0000 (22:01 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 10 May 2022 07:48:08 +0000 (09:48 +0200)
ptp_convert_timestamp() converts only the timestamp hwtstamp, which is
a field of the argument with the type struct skb_shared_hwtstamps *. So
a pointer to the hwtstamp field of this structure is sufficient.

Rework ptp_convert_timestamp() to use an argument of type ktime_t *.
This allows to add additional timestamp manipulation stages before the
call of ptp_convert_timestamp().

Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/ptp/ptp_vclock.c
include/linux/ptp_clock_kernel.h
net/socket.c

index 3a095ea..c30bcce 100644 (file)
@@ -232,8 +232,7 @@ out:
 }
 EXPORT_SYMBOL(ptp_get_vclocks_index);
 
-ktime_t ptp_convert_timestamp(const struct skb_shared_hwtstamps *hwtstamps,
-                             int vclock_index)
+ktime_t ptp_convert_timestamp(const ktime_t *hwtstamp, int vclock_index)
 {
        char name[PTP_CLOCK_NAME_LEN] = "";
        struct ptp_vclock *vclock;
@@ -255,7 +254,7 @@ ktime_t ptp_convert_timestamp(const struct skb_shared_hwtstamps *hwtstamps,
 
        vclock = info_to_vclock(ptp->info);
 
-       ns = ktime_to_ns(hwtstamps->hwtstamp);
+       ns = ktime_to_ns(*hwtstamp);
 
        spin_lock_irqsave(&vclock->lock, flags);
        ns = timecounter_cyc2time(&vclock->tc, ns);
index ad30920..92b4416 100644 (file)
@@ -384,17 +384,16 @@ int ptp_get_vclocks_index(int pclock_index, int **vclock_index);
 /**
  * ptp_convert_timestamp() - convert timestamp to a ptp vclock time
  *
- * @hwtstamps:    skb_shared_hwtstamps structure pointer
+ * @hwtstamp:     timestamp
  * @vclock_index: phc index of ptp vclock.
  *
  * Returns converted timestamp, or 0 on error.
  */
-ktime_t ptp_convert_timestamp(const struct skb_shared_hwtstamps *hwtstamps,
-                             int vclock_index);
+ktime_t ptp_convert_timestamp(const ktime_t *hwtstamp, int vclock_index);
 #else
 static inline int ptp_get_vclocks_index(int pclock_index, int **vclock_index)
 { return 0; }
-static inline ktime_t ptp_convert_timestamp(const struct skb_shared_hwtstamps *hwtstamps,
+static inline ktime_t ptp_convert_timestamp(const ktime_t *hwtstamp,
                                            int vclock_index)
 { return 0; }
 
index 5c1c5e6..0f680c7 100644 (file)
@@ -888,7 +888,7 @@ void __sock_recv_timestamp(struct msghdr *msg, struct sock *sk,
            (sk->sk_tsflags & SOF_TIMESTAMPING_RAW_HARDWARE) &&
            !skb_is_swtx_tstamp(skb, false_tstamp)) {
                if (sk->sk_tsflags & SOF_TIMESTAMPING_BIND_PHC)
-                       hwtstamp = ptp_convert_timestamp(shhwtstamps,
+                       hwtstamp = ptp_convert_timestamp(&shhwtstamps->hwtstamp,
                                                         sk->sk_bind_phc);
                else
                        hwtstamp = shhwtstamps->hwtstamp;