PM / hibernate: cast PAGE_SIZE to int when comparing with error code
authorChengguang Xu <cgxu519@gmx.com>
Mon, 25 Jun 2018 05:30:58 +0000 (13:30 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 2 Jul 2018 09:48:30 +0000 (11:48 +0200)
If PAGE_SIZE is unsigned type then negative error code will be
larger than PAGE_SIZE.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
kernel/power/swap.c

index c2bcf97..d7f6c1a 100644 (file)
@@ -923,7 +923,7 @@ int swsusp_write(unsigned int flags)
        }
        memset(&snapshot, 0, sizeof(struct snapshot_handle));
        error = snapshot_read_next(&snapshot);
-       if (error < PAGE_SIZE) {
+       if (error < (int)PAGE_SIZE) {
                if (error >= 0)
                        error = -EFAULT;
 
@@ -1483,7 +1483,7 @@ int swsusp_read(unsigned int *flags_p)
 
        memset(&snapshot, 0, sizeof(struct snapshot_handle));
        error = snapshot_write_next(&snapshot);
-       if (error < PAGE_SIZE)
+       if (error < (int)PAGE_SIZE)
                return error < 0 ? error : -EFAULT;
        header = (struct swsusp_info *)data_of(snapshot);
        error = get_swap_reader(&handle, flags_p);