brcmsmac: make const array ucode_ofdm_rates static, reduces object code size
authorColin Ian King <colin.king@canonical.com>
Fri, 22 Sep 2017 14:03:16 +0000 (15:03 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 25 Sep 2017 08:23:10 +0000 (11:23 +0300)
Don't populate const array ucode_ofdm_rates on the stack, instead make it
static. Makes the object code smaller by 100 bytes:

Before:
   text    data     bss     dec     hex filename
  39482     564       0   40046    9c6e phy_cmn.o

After
   text    data     bss     dec     hex filename
  39326     620       0   39946    9c0a phy_cmn.o

(gcc 6.3.0, x86-64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c

index 1c4e9dd..3a13d17 100644 (file)
@@ -1916,7 +1916,7 @@ void wlc_phy_txpower_update_shm(struct brcms_phy *pi)
                                     pi->hwpwr_txcur);
 
                for (j = TXP_FIRST_OFDM; j <= TXP_LAST_OFDM; j++) {
-                       const u8 ucode_ofdm_rates[] = {
+                       static const u8 ucode_ofdm_rates[] = {
                                0x0c, 0x12, 0x18, 0x24, 0x30, 0x48, 0x60, 0x6c
                        };
                        offset = wlapi_bmac_rate_shm_offset(