projects
/
kernel
/
kernel-generic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
65afac7
)
param: fix NULL comparison on oom
author
Rusty Russell
<rusty@rustcorp.com.au>
Thu, 29 Oct 2009 14:56:17 +0000
(08:56 -0600)
committer
Rusty Russell
<rusty@rustcorp.com.au>
Wed, 28 Oct 2009 22:26:18 +0000
(08:56 +1030)
kp->arg is always true: it's the contents of that pointer we care about.
Reported-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: stable@kernel.org
kernel/params.c
patch
|
blob
|
history
diff --git
a/kernel/params.c
b/kernel/params.c
index
95ef27c
..
00520c4
100644
(file)
--- a/
kernel/params.c
+++ b/
kernel/params.c
@@
-222,7
+222,7
@@
int param_set_charp(const char *val, struct kernel_param *kp)
* don't need to; this mangled commandline is preserved. */
if (slab_is_available()) {
*(char **)kp->arg = kstrdup(val, GFP_KERNEL);
- if (!kp->arg)
+ if (!
*(char **)
kp->arg)
return -ENOMEM;
} else
*(const char **)kp->arg = val;