staging: unisys: Add checks for creation
authorDon Zickus <dzickus@redhat.com>
Wed, 13 May 2015 17:22:21 +0000 (13:22 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 24 May 2015 20:28:56 +0000 (13:28 -0700)
There was a bunch of channel creation checks before the
visorchannel_create function was called, moving some of those
checks inside.  This keeps the outside code cleaner and handles
the situation where a caller forgets to make these checks.

Signed-off-by: Don Zickus <dzickus@redhat.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/visorchannel.c

index 1789f9d..6e7675e 100644 (file)
@@ -62,6 +62,9 @@ visorchannel_create_guts(u64 physaddr, unsigned long channel_bytes,
        int err;
        size_t size = sizeof(struct channel_header);
 
+       if (physaddr == 0)
+               return NULL;
+
        channel = kzalloc(sizeof(*channel), gfp);
        if (!channel)
                goto cleanup;