SMACK: Delete list_head repeated initialization
authorHimanshu Shukla <himanshu.sh@samsung.com>
Wed, 23 Nov 2016 06:28:48 +0000 (11:58 +0530)
committerCasey Schaufler <casey@schaufler-ca.com>
Tue, 10 Jan 2017 17:47:20 +0000 (09:47 -0800)
smk_copy_rules() and smk_copy_relabel() are initializing list_head though
they have been initialized already in new_task_smack() function. Delete
repeated initialization.

Signed-off-by: Himanshu Shukla <himanshu.sh@samsung.com>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
security/smack/smack_lsm.c

index ed6885b..1368f89 100644 (file)
@@ -348,8 +348,6 @@ static int smk_copy_rules(struct list_head *nhead, struct list_head *ohead,
        struct smack_rule *orp;
        int rc = 0;
 
-       INIT_LIST_HEAD(nhead);
-
        list_for_each_entry_rcu(orp, ohead, list) {
                nrp = kzalloc(sizeof(struct smack_rule), gfp);
                if (nrp == NULL) {
@@ -376,8 +374,6 @@ static int smk_copy_relabel(struct list_head *nhead, struct list_head *ohead,
        struct smack_known_list_elem *nklep;
        struct smack_known_list_elem *oklep;
 
-       INIT_LIST_HEAD(nhead);
-
        list_for_each_entry(oklep, ohead, list) {
                nklep = kzalloc(sizeof(struct smack_known_list_elem), gfp);
                if (nklep == NULL) {