efifb: Check efifb_pci_dev before using it
authorKai-Heng Feng <kai.heng.feng@canonical.com>
Tue, 13 Apr 2021 17:05:08 +0000 (01:05 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 13 Apr 2021 22:19:11 +0000 (18:19 -0400)
On some platforms like Hyper-V and RPi4 with UEFI firmware, efifb is not
a PCI device.

So make sure efifb_pci_dev is found before using it.

Fixes: a6c0fd3d5a8b ("efifb: Ensure graphics device for efifb stays at PCI D0")
BugLink: https://bugs.launchpad.net/bugs/1922403
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210413170508.968148-1-kai.heng.feng@canonical.com
drivers/video/fbdev/efifb.c

index f58a545..8ea8f07 100644 (file)
@@ -575,7 +575,8 @@ static int efifb_probe(struct platform_device *dev)
                goto err_fb_dealoc;
        }
        fb_info(info, "%s frame buffer device\n", info->fix.id);
-       pm_runtime_get_sync(&efifb_pci_dev->dev);
+       if (efifb_pci_dev)
+               pm_runtime_get_sync(&efifb_pci_dev->dev);
        return 0;
 
 err_fb_dealoc:
@@ -602,7 +603,8 @@ static int efifb_remove(struct platform_device *pdev)
        unregister_framebuffer(info);
        sysfs_remove_groups(&pdev->dev.kobj, efifb_groups);
        framebuffer_release(info);
-       pm_runtime_put(&efifb_pci_dev->dev);
+       if (efifb_pci_dev)
+               pm_runtime_put(&efifb_pci_dev->dev);
 
        return 0;
 }