i3c: master: Free the old_dyn_addr when reattach.
authorBilly Tsai <billy_tsai@aspeedtech.com>
Mon, 26 Sep 2022 10:51:44 +0000 (18:51 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Wed, 12 Oct 2022 21:45:29 +0000 (23:45 +0200)
This patch is used to free the old_dyn_addr when the caller want to
reattach the device to the different dynamic address. If the
old_dyn_addr is 0 the function will treat it as no old_dyn_addr is
reserved on the bus. Without the patch, when the driver reattach the i3c
device after setnewda the old_dyn_addr will be permanently occupied.

Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Link: https://lore.kernel.org/r/20220926105145.8145-1-billy_tsai@aspeedtech.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/i3c/master.c

index 7850287..6349ce0 100644 (file)
@@ -1379,6 +1379,9 @@ static int i3c_master_reattach_i3c_dev(struct i3c_dev_desc *dev,
                i3c_bus_set_addr_slot_status(&master->bus,
                                             dev->info.dyn_addr,
                                             I3C_ADDR_SLOT_I3C_DEV);
+               if (old_dyn_addr)
+                       i3c_bus_set_addr_slot_status(&master->bus, old_dyn_addr,
+                                                    I3C_ADDR_SLOT_FREE);
        }
 
        if (master->ops->reattach_i3c_dev) {