controller: add the missing abi padding
authorStefan Sauer <ensonic@users.sf.net>
Mon, 28 Sep 2015 14:19:40 +0000 (16:19 +0200)
committerStefan Sauer <ensonic@users.sf.net>
Mon, 28 Sep 2015 14:23:41 +0000 (16:23 +0200)
While this technically is an abi break, we decided to do this:
1) the struct is documented to be internal
2) the struct is alloced and freed inside the library
3) there are no public methods that receive or return instances
4) the only code known to use this struct are classes containd here

libs/gst/controller/gsttimedvaluecontrolsource.h
tests/check/libs/struct_arm.h
tests/check/libs/struct_hppa.h
tests/check/libs/struct_i386.h
tests/check/libs/struct_ppc32.h
tests/check/libs/struct_ppc64.h
tests/check/libs/struct_sparc.h
tests/check/libs/struct_x86_64.h

index 7bc901e..d161ecb 100644 (file)
@@ -55,7 +55,7 @@ typedef struct _GstControlPoint GstControlPoint;
  * @timestamp: timestamp of the value change
  * @value: the new value
  *
- * a internal structure for value+time and various temporary
+ * An internal structure for value+time and various temporary
  * values used for interpolation. This "inherits" from
  * GstTimedValue.
  */
@@ -77,8 +77,8 @@ struct _GstControlPoint
     struct {
       gdouble c1s, c2s, c3s;
     } cubic_mono;
+    gpointer _gst_reserved[GST_PADDING];
   } cache;
-
 };
 
 GType gst_control_point_get_type (void);
index 8c99bf2..ecb0f58 100644 (file)
@@ -22,7 +22,7 @@ GstCheckABIStruct list[] = {
   {"GstInterpolationControlSource", sizeof (GstInterpolationControlSource), 152},
   {"GstLFOControlSourceClass", sizeof (GstLFOControlSourceClass), 124},
   {"GstLFOControlSource", sizeof (GstLFOControlSource), 120},
-  {"GstControlPoint", sizeof (GstControlPoint), 32},
+  {"GstControlPoint", sizeof (GstControlPoint), 48},
   {"GstTimedValueControlSourceClass", sizeof (GstTimedValueControlSourceClass), 124},
   {"GstTimedValueControlSource", sizeof (GstTimedValueControlSource), 128},
   {"GstTriggerControlSourceClass", sizeof (GstTriggerControlSourceClass), 140},
index 484298e..1915e4f 100644 (file)
@@ -22,7 +22,7 @@ GstCheckABIStruct list[] = {
   {"GstInterpolationControlSource", sizeof (GstInterpolationControlSource), 240},
   {"GstLFOControlSourceClass", sizeof (GstLFOControlSourceClass), 248},
   {"GstLFOControlSource", sizeof (GstLFOControlSource), 184},
-  {"GstControlPoint", sizeof (GstControlPoint), 32},
+  {"GstControlPoint", sizeof (GstControlPoint), 48},
   {"GstTimedValueControlSourceClass", sizeof (GstTimedValueControlSourceClass), 248},
   {"GstTimedValueControlSource", sizeof (GstTimedValueControlSource), 200},
   {"GstTriggerControlSourceClass", sizeof (GstTriggerControlSourceClass), 280},
index 3f1e938..8cf7343 100644 (file)
@@ -22,7 +22,7 @@ GstCheckABIStruct list[] = {
   {"GstInterpolationControlSource", sizeof (GstInterpolationControlSource), 140},
   {"GstLFOControlSourceClass", sizeof (GstLFOControlSourceClass), 124},
   {"GstLFOControlSource", sizeof (GstLFOControlSource), 108},
-  {"GstControlPoint", sizeof (GstControlPoint), 32},
+  {"GstControlPoint", sizeof (GstControlPoint), 48},
   {"GstTimedValueControlSourceClass", sizeof (GstTimedValueControlSourceClass), 124},
   {"GstTimedValueControlSource", sizeof (GstTimedValueControlSource), 120},
   {"GstTriggerControlSourceClass", sizeof (GstTriggerControlSourceClass), 140},
index 8c99bf2..ecb0f58 100644 (file)
@@ -22,7 +22,7 @@ GstCheckABIStruct list[] = {
   {"GstInterpolationControlSource", sizeof (GstInterpolationControlSource), 152},
   {"GstLFOControlSourceClass", sizeof (GstLFOControlSourceClass), 124},
   {"GstLFOControlSource", sizeof (GstLFOControlSource), 120},
-  {"GstControlPoint", sizeof (GstControlPoint), 32},
+  {"GstControlPoint", sizeof (GstControlPoint), 48},
   {"GstTimedValueControlSourceClass", sizeof (GstTimedValueControlSourceClass), 124},
   {"GstTimedValueControlSource", sizeof (GstTimedValueControlSource), 128},
   {"GstTriggerControlSourceClass", sizeof (GstTriggerControlSourceClass), 140},
index 484298e..1915e4f 100644 (file)
@@ -22,7 +22,7 @@ GstCheckABIStruct list[] = {
   {"GstInterpolationControlSource", sizeof (GstInterpolationControlSource), 240},
   {"GstLFOControlSourceClass", sizeof (GstLFOControlSourceClass), 248},
   {"GstLFOControlSource", sizeof (GstLFOControlSource), 184},
-  {"GstControlPoint", sizeof (GstControlPoint), 32},
+  {"GstControlPoint", sizeof (GstControlPoint), 48},
   {"GstTimedValueControlSourceClass", sizeof (GstTimedValueControlSourceClass), 248},
   {"GstTimedValueControlSource", sizeof (GstTimedValueControlSource), 200},
   {"GstTriggerControlSourceClass", sizeof (GstTriggerControlSourceClass), 280},
index 484298e..1915e4f 100644 (file)
@@ -22,7 +22,7 @@ GstCheckABIStruct list[] = {
   {"GstInterpolationControlSource", sizeof (GstInterpolationControlSource), 240},
   {"GstLFOControlSourceClass", sizeof (GstLFOControlSourceClass), 248},
   {"GstLFOControlSource", sizeof (GstLFOControlSource), 184},
-  {"GstControlPoint", sizeof (GstControlPoint), 32},
+  {"GstControlPoint", sizeof (GstControlPoint), 48},
   {"GstTimedValueControlSourceClass", sizeof (GstTimedValueControlSourceClass), 248},
   {"GstTimedValueControlSource", sizeof (GstTimedValueControlSource), 200},
   {"GstTriggerControlSourceClass", sizeof (GstTriggerControlSourceClass), 280},
index 484298e..1915e4f 100644 (file)
@@ -22,7 +22,7 @@ GstCheckABIStruct list[] = {
   {"GstInterpolationControlSource", sizeof (GstInterpolationControlSource), 240},
   {"GstLFOControlSourceClass", sizeof (GstLFOControlSourceClass), 248},
   {"GstLFOControlSource", sizeof (GstLFOControlSource), 184},
-  {"GstControlPoint", sizeof (GstControlPoint), 32},
+  {"GstControlPoint", sizeof (GstControlPoint), 48},
   {"GstTimedValueControlSourceClass", sizeof (GstTimedValueControlSourceClass), 248},
   {"GstTimedValueControlSource", sizeof (GstTimedValueControlSource), 200},
   {"GstTriggerControlSourceClass", sizeof (GstTriggerControlSourceClass), 280},