RDMA/srpt: Make debug output more detailed
authorBart Van Assche <bvanassche@acm.org>
Mon, 25 May 2020 17:22:10 +0000 (10:22 -0700)
committerJason Gunthorpe <jgg@mellanox.com>
Fri, 29 May 2020 17:49:55 +0000 (14:49 -0300)
Since the session name by itself is not sufficient to uniquely identify a
queue pair, include the queue pair number. Show the ASCII channel state
name instead of the numeric value. This change makes the ib_srpt debug
output more consistent.

Link: https://lore.kernel.org/r/20200525172212.14413-3-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/ulp/srpt/ib_srpt.c

index cdc8c23..b96e91e 100644 (file)
@@ -214,8 +214,9 @@ static const char *get_ch_state_name(enum rdma_ch_state s)
  */
 static void srpt_qp_event(struct ib_event *event, struct srpt_rdma_ch *ch)
 {
-       pr_debug("QP event %d on ch=%p sess_name=%s state=%d\n",
-                event->event, ch, ch->sess_name, ch->state);
+       pr_debug("QP event %d on ch=%p sess_name=%s-%d state=%s\n",
+                event->event, ch, ch->sess_name, ch->qp->qp_num,
+                get_ch_state_name(ch->state));
 
        switch (event->event) {
        case IB_EVENT_COMM_EST:
@@ -1985,8 +1986,8 @@ static void __srpt_close_all_ch(struct srpt_port *sport)
        list_for_each_entry(nexus, &sport->nexus_list, entry) {
                list_for_each_entry(ch, &nexus->ch_list, list) {
                        if (srpt_disconnect_ch(ch) >= 0)
-                               pr_info("Closing channel %s because target %s_%d has been disabled\n",
-                                       ch->sess_name,
+                               pr_info("Closing channel %s-%d because target %s_%d has been disabled\n",
+                                       ch->sess_name, ch->qp->qp_num,
                                        dev_name(&sport->sdev->device->dev),
                                        sport->port);
                        srpt_close_ch(ch);