Remove `Ops` suffix from dialect library names
authorGeoffrey Martin-Noble <gcmn@google.com>
Thu, 1 Oct 2020 00:47:25 +0000 (17:47 -0700)
committerStella Laurenzo <stellaraccident@gmail.com>
Thu, 1 Oct 2020 01:00:44 +0000 (18:00 -0700)
Dialects include more than just ops, so this suffix is outdated. Follows
discussion in
https://llvm.discourse.group/t/rfc-canonical-file-paths-to-dialects/621

Reviewed By: stellaraccident

Differential Revision: https://reviews.llvm.org/D88530

36 files changed:
flang/lib/Lower/CMakeLists.txt
mlir/docs/Tutorials/CreatingADialect.md
mlir/lib/Analysis/CMakeLists.txt
mlir/lib/CAPI/Standard/CMakeLists.txt
mlir/lib/Conversion/AffineToStandard/CMakeLists.txt
mlir/lib/Conversion/GPUToSPIRV/CMakeLists.txt
mlir/lib/Conversion/GPUToVulkan/CMakeLists.txt
mlir/lib/Conversion/LinalgToLLVM/CMakeLists.txt
mlir/lib/Conversion/LinalgToSPIRV/CMakeLists.txt
mlir/lib/Conversion/LinalgToStandard/CMakeLists.txt
mlir/lib/Conversion/SCFToGPU/CMakeLists.txt
mlir/lib/Conversion/SCFToSPIRV/CMakeLists.txt
mlir/lib/Conversion/StandardToSPIRV/CMakeLists.txt
mlir/lib/Dialect/Affine/EDSC/CMakeLists.txt
mlir/lib/Dialect/Affine/IR/CMakeLists.txt
mlir/lib/Dialect/Affine/Transforms/CMakeLists.txt
mlir/lib/Dialect/Affine/Utils/CMakeLists.txt
mlir/lib/Dialect/GPU/CMakeLists.txt
mlir/lib/Dialect/Linalg/Analysis/CMakeLists.txt
mlir/lib/Dialect/Linalg/EDSC/CMakeLists.txt
mlir/lib/Dialect/Linalg/IR/CMakeLists.txt
mlir/lib/Dialect/Linalg/Transforms/CMakeLists.txt
mlir/lib/Dialect/Linalg/Utils/CMakeLists.txt
mlir/lib/Dialect/Quant/CMakeLists.txt
mlir/lib/Dialect/SCF/CMakeLists.txt
mlir/lib/Dialect/SCF/Transforms/CMakeLists.txt
mlir/lib/Dialect/Shape/IR/CMakeLists.txt
mlir/lib/Dialect/StandardOps/CMakeLists.txt
mlir/lib/Dialect/StandardOps/Transforms/CMakeLists.txt
mlir/lib/Dialect/Vector/CMakeLists.txt
mlir/lib/ExecutionEngine/CMakeLists.txt
mlir/lib/Transforms/CMakeLists.txt
mlir/lib/Transforms/Utils/CMakeLists.txt
mlir/test/EDSC/CMakeLists.txt
mlir/test/lib/Dialect/Test/CMakeLists.txt
mlir/test/lib/Transforms/CMakeLists.txt

index e104a8f..07b87ef 100644 (file)
@@ -30,7 +30,7 @@ add_flang_library(FortranLower
   MLIRAffineToStandard
   MLIRLLVMIR
   MLIRSCFToStandard
-  MLIRStandardOps
+  MLIRStandard
 
   LINK_COMPONENTS
   Support
index 9f9eb7a..17d2ec9 100644 (file)
@@ -26,7 +26,7 @@ typically described in TableGen file using the [DDR
 format](DeclarativeRewrites.md).
 
 Note that dialect names should not generally be suffixed with “Ops”,
-although some files pertaining to the operations of a dialect (e.g.
+although some files pertaining only to the operations of a dialect (e.g.
 FooOps.cpp) might be.
 
 ## CMake best practices
@@ -38,10 +38,8 @@ tablegen in a file FooOps.td.  This file forms the core of a dialect and
 is declared using add_mlir_dialect().
 
 ```cmake
-
 add_mlir_dialect(FooOps foo)
 add_mlir_doc(FooOps -gen-dialect-doc FooDialect Dialects/)
-
 ```
 
 This generates the correct rules to run mlir-tblgen, along with a
@@ -49,6 +47,7 @@ This generates the correct rules to run mlir-tblgen, along with a
 
 Dialect transformations are typically declared in a file FooTransforms.td.
 Targets for TableGen are described in typical llvm fashion.
+
 ```cmake
 set(LLVM_TARGET_DEFINITIONS FooTransforms.td)
 mlir_tablegen(FooTransforms.h.inc -gen-rewriters)
@@ -67,20 +66,18 @@ other dialect libraries.  Typically this dependence is declared using
 target_link_libraries() and the PUBLIC keyword.  For instance:
 
 ```cmake
-
-add_mlir_dialect_library(FooOps
-       DEPENDS
-       MLIRFooOpsIncGen
-       MLIRFooTransformsIncGen
-
-       LINK_COMPONENTS
-       Core
-
-       LINK_LIBS PUBLIC
-       BarOps
-       <some-other-library>
-   )
-
+add_mlir_dialect_library(MLIRFoo
+  DEPENDS
+  MLIRFooOpsIncGen
+  MLIRFooTransformsIncGen
+
+  LINK_COMPONENTS
+  Core
+
+  LINK_LIBS PUBLIC
+  MLIRBar
+  <some-other-library>
+  )
 ```
 
 add_mlir_dialect_library() is a thin wrapper around add_llvm_library()
@@ -90,9 +87,7 @@ access to all dialects.  This list is also linked into libMLIR.so.
 The list can be retrieved from the MLIR_DIALECT_LIBS global property:
 
 ```cmake
-
 get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
-
 ```
 
 Note that although the Bar dialect also uses TableGen to declare its
@@ -139,18 +134,16 @@ dialects (e.g. MLIRStandard).  Typically this dependence is specified
 using target_link_libraries() and the PUBLIC keyword.  For instance:
 
 ```cmake
-
 add_mlir_conversion_library(MLIRBarToFoo
-       BarToFoo.cpp
+  BarToFoo.cpp
 
-        ADDITIONAL_HEADER_DIRS
-        ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/BarToFoo
-
-   LINK_LIBS PUBLIC
-       BarOps
-       FooOps
-       )
+  ADDITIONAL_HEADER_DIRS
+  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/BarToFoo
 
+  LINK_LIBS PUBLIC
+  MLIRBar
+  MLIRFoo
+  )
 ```
 
 add_mlir_conversion_library() is a thin wrapper around
@@ -161,9 +154,7 @@ is also linked in libMLIR.so.  The list can be retrieved from the
 MLIR_CONVERSION_LIBS global property:
 
 ```cmake
-
 get_property(dialect_libs GLOBAL PROPERTY MLIR_CONVERSION_LIBS)
-
 ```
 
 Note that it is only necessary to specify a PUBLIC dependence against
index 524203b..217a949 100644 (file)
@@ -21,7 +21,7 @@ add_mlir_library(MLIRAnalysis
   mlir-headers
 
   LINK_LIBS PUBLIC
-  MLIRAffineOps
+  MLIRAffine
   MLIRCallInterfaces
   MLIRControlFlowInterfaces
   MLIRInferTypeOpInterface
@@ -43,7 +43,7 @@ add_mlir_library(MLIRLoopAnalysis
   mlir-headers
 
   LINK_LIBS PUBLIC
-  MLIRAffineOps
+  MLIRAffine
   MLIRCallInterfaces
   MLIRControlFlowInterfaces
   MLIRInferTypeOpInterface
index 662841c..c841166 100644 (file)
@@ -7,5 +7,5 @@ add_mlir_library(MLIRCAPIStandard
 
   LINK_LIBS PUBLIC
   MLIRCAPIIR
-  MLIRStandardOps
+  MLIRStandard
   )
index 47a371f..45c3981 100644 (file)
@@ -11,10 +11,10 @@ add_mlir_conversion_library(MLIRAffineToStandard
   Core
 
   LINK_LIBS PUBLIC
-  MLIRAffineOps
+  MLIRAffine
   MLIRSCF
   MLIRPass
-  MLIRStandardOps
+  MLIRStandard
   MLIRTransforms
   MLIRIR
   )
index cce793f..2da9c70 100644 (file)
@@ -16,7 +16,7 @@ add_mlir_conversion_library(MLIRGPUToSPIRVTransforms
   MLIRPass
   MLIRSCFToSPIRV
   MLIRSPIRV
-  MLIRStandardOps
+  MLIRStandard
   MLIRStandardToSPIRVTransforms
   MLIRSupport
   MLIRTransforms
index b62f72f..6573352 100644 (file)
@@ -12,7 +12,7 @@ add_mlir_conversion_library(MLIRGPUToVulkanTransforms
   MLIRPass
   MLIRSPIRV
   MLIRSPIRVSerialization
-  MLIRStandardOps
+  MLIRStandard
   MLIRSupport
   MLIRTransforms
   MLIRTranslation
index d507b41..9ae00bf 100644 (file)
@@ -15,7 +15,7 @@ add_mlir_conversion_library(MLIRLinalgToLLVM
   MLIRAffineToStandard
   MLIREDSC
   MLIRIR
-  MLIRLinalgOps
+  MLIRLinalg
   MLIRLLVMIR
   MLIRSCFToStandard
   MLIRStandardToLLVM
index 98553ad..e76e9b7 100644 (file)
@@ -11,7 +11,7 @@ add_mlir_conversion_library(MLIRLinalgToSPIRVTransforms
 
   LINK_LIBS PUBLIC
   MLIRIR
-  MLIRLinalgOps
+  MLIRLinalg
   MLIRLinalgUtils
   MLIRPass
   MLIRSPIRV
index 8cfb315..b38a4b8 100644 (file)
@@ -13,7 +13,7 @@ add_mlir_conversion_library(MLIRLinalgToStandard
   LINK_LIBS PUBLIC
   MLIREDSC
   MLIRIR
-  MLIRLinalgOps
+  MLIRLinalg
   MLIRPass
   MLIRSCF
   MLIRTransforms
index 1da4dac..10fed81 100644 (file)
@@ -9,13 +9,13 @@ add_mlir_conversion_library(MLIRSCFToGPU
   MLIRConversionPassIncGen
 
   LINK_LIBS PUBLIC
-  MLIRAffineOps
+  MLIRAffine
   MLIRAffineToStandard
   MLIRGPU
   MLIRIR
-  MLIRLinalgOps
+  MLIRLinalg
   MLIRPass
-  MLIRStandardOps
+  MLIRStandard
   MLIRSupport
   MLIRTransforms
   )
index 6d95813..1a38676 100644 (file)
@@ -8,13 +8,13 @@ add_mlir_conversion_library(MLIRSCFToSPIRV
   MLIRConversionPassIncGen
 
   LINK_LIBS PUBLIC
-  MLIRAffineOps
+  MLIRAffine
   MLIRAffineToStandard
   MLIRSPIRV
   MLIRIR
-  MLIRLinalgOps
+  MLIRLinalg
   MLIRPass
-  MLIRStandardOps
+  MLIRStandard
   MLIRSupport
   MLIRTransforms
   )
index e609859..5ccbcc6 100644 (file)
@@ -17,5 +17,5 @@ add_mlir_conversion_library(MLIRStandardToSPIRVTransforms
   MLIRSupport
   MLIRTransformUtils
   MLIRSPIRV
-  MLIRStandardOps
+  MLIRStandard
   )
index a0e8b6f..e753f4e 100644 (file)
@@ -8,10 +8,10 @@ add_mlir_dialect_library(MLIRAffineEDSC
   MLIRAffineOpsIncGen
 
   LINK_LIBS PUBLIC
-  MLIRAffineOps
+  MLIRAffine
   MLIREDSC
   MLIRIR
   MLIRLoopLikeInterface
   MLIRSideEffectInterfaces
-  MLIRStandardOps
+  MLIRStandard
   )
index 20bc863..0315338 100644 (file)
@@ -1,4 +1,4 @@
-add_mlir_dialect_library(MLIRAffineOps
+add_mlir_dialect_library(MLIRAffine
   AffineMemoryOpInterfaces.cpp
   AffineOps.cpp
   AffineValueMap.cpp
@@ -15,5 +15,5 @@ add_mlir_dialect_library(MLIRAffineOps
   MLIRIR
   MLIRLoopLikeInterface
   MLIRSideEffectInterfaces
-  MLIRStandardOps
+  MLIRStandard
   )
index c1d406a..899f362 100644 (file)
@@ -18,13 +18,13 @@ add_mlir_dialect_library(MLIRAffineTransforms
   MLIRLoopLikeInterfaceIncGen
 
   LINK_LIBS PUBLIC
-  MLIRAffineOps
+  MLIRAffine
   MLIRAffineUtils
   MLIREDSC
   MLIRIR
   MLIRPass
   MLIRSideEffectInterfaces
-  MLIRStandardOps
+  MLIRStandard
   MLIRTransformUtils
   MLIRVector
   MLIRVectorToLLVM
index 59ae13d..e4a5d0b 100644 (file)
@@ -5,6 +5,6 @@ add_mlir_dialect_library(MLIRAffineUtils
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine
 
   LINK_LIBS PUBLIC
-  MLIRAffineOps
+  MLIRAffine
   MLIRTransformUtils
   )
index cdb06f4..d62ea7a 100644 (file)
@@ -21,7 +21,7 @@ add_mlir_dialect_library(MLIRGPU
   MLIRSCF
   MLIRPass
   MLIRSideEffectInterfaces
-  MLIRStandardOps
+  MLIRStandard
   MLIRSupport
   MLIRTransformUtils
   )
index 5bb5623..b7c7a67 100644 (file)
@@ -1,11 +1,11 @@
 add_mlir_dialect_library(MLIRLinalgAnalysis
   DependenceAnalysis.cpp
-  
+
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
 
   LINK_LIBS PUBLIC
   MLIRIR
-  MLIRLinalgOps
-  MLIRStandardOps
+  MLIRLinalg
+  MLIRStandard
   )
index 91fdaa4..d7f4fff 100644 (file)
@@ -7,9 +7,9 @@ add_mlir_dialect_library(MLIRLinalgEDSC
   LINK_LIBS PUBLIC
   MLIREDSC
   MLIRIR
-  MLIRAffineOps
+  MLIRAffine
   MLIRAffineEDSC
-  MLIRLinalgOps
+  MLIRLinalg
   MLIRSCF
-  MLIRStandardOps
+  MLIRStandard
   )
index 3cd3401..963260a 100644 (file)
@@ -1,4 +1,4 @@
-add_mlir_dialect_library(MLIRLinalgOps
+add_mlir_dialect_library(MLIRLinalg
   LinalgOps.cpp
   LinalgTypes.cpp
 
@@ -14,5 +14,5 @@ add_mlir_dialect_library(MLIRLinalgOps
   MLIRIR
   MLIRSideEffectInterfaces
   MLIRViewLikeInterface
-  MLIRStandardOps
+  MLIRStandard
   )
index 73cd919..a281aa5 100644 (file)
@@ -17,18 +17,18 @@ add_mlir_dialect_library(MLIRLinalgTransforms
   MLIRLinalgPassIncGen
 
   LINK_LIBS PUBLIC
-  MLIRAffineOps
+  MLIRAffine
   MLIRAnalysis
   MLIREDSC
   MLIRIR
   MLIRLinalgAnalysis
   MLIRLinalgEDSC
-  MLIRLinalgOps
+  MLIRLinalg
   MLIRLinalgUtils
   MLIRSCF
   MLIRSCFTransforms
   MLIRPass
-  MLIRStandardOps
+  MLIRStandard
   MLIRStandardToLLVM
   MLIRTransformUtils
   MLIRVector
index 8b3e897..0d092dd 100644 (file)
@@ -5,13 +5,13 @@ add_mlir_dialect_library(MLIRLinalgUtils
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
 
   LINK_LIBS PUBLIC
-  MLIRAffineOps
+  MLIRAffine
   MLIREDSC
   MLIRIR
   MLIRLinalgEDSC
-  MLIRLinalgOps
+  MLIRLinalg
   MLIRSCF
   MLIRPass
-  MLIRStandardOps
+  MLIRStandard
   MLIRTransformUtils
   )
index 130a415..f95b6ce 100644 (file)
@@ -21,6 +21,6 @@ add_mlir_dialect_library(MLIRQuant
   MLIRPass
   MLIRSideEffectInterfaces
   MLIRSupport
-  MLIRStandardOps
+  MLIRStandard
   MLIRTransformUtils
   )
index a480510..297e918 100644 (file)
@@ -13,7 +13,7 @@ add_mlir_dialect_library(MLIRSCF
   MLIRIR
   MLIRLoopLikeInterface
   MLIRSideEffectInterfaces
-  MLIRStandardOps
+  MLIRStandard
   )
 
 add_subdirectory(Transforms)
index 341780c..b3b2002 100644 (file)
@@ -11,11 +11,11 @@ add_mlir_dialect_library(MLIRSCFTransforms
   MLIRSCFPassIncGen
 
   LINK_LIBS PUBLIC
-  MLIRAffineOps
+  MLIRAffine
   MLIRIR
   MLIRPass
   MLIRSCF
-  MLIRStandardOps
+  MLIRStandard
   MLIRSupport
   MLIRTransformUtils
 )
index e39f1c7..1ac5b3b 100644 (file)
@@ -17,5 +17,5 @@ add_mlir_dialect_library(MLIRShape
   MLIRInferTypeOpInterface
   MLIRIR
   MLIRSideEffectInterfaces
-  MLIRStandardOps
+  MLIRStandard
   )
index 06284f5..e5188ec 100644 (file)
@@ -1,4 +1,4 @@
-add_mlir_dialect_library(MLIRStandardOps
+add_mlir_dialect_library(MLIRStandard
   IR/Ops.cpp
   EDSC/Builders.cpp
   EDSC/Intrinsics.cpp
index 299fc2b..d1204df 100644 (file)
@@ -12,6 +12,6 @@ add_mlir_dialect_library(MLIRStandardOpsTransforms
   LINK_LIBS PUBLIC
   MLIRIR
   MLIRPass
-  MLIRStandardOps
+  MLIRStandard
   MLIRTransforms
   )
index 1087feb..7c8c58e 100644 (file)
@@ -14,9 +14,9 @@ add_mlir_dialect_library(MLIRVector
   MLIRAffineEDSC
   MLIREDSC
   MLIRIR
-  MLIRStandardOps
-  MLIRAffineOps
-  MLIRLinalgOps
+  MLIRStandard
+  MLIRAffine
+  MLIRLinalg
   MLIRSCF
   MLIRLoopAnalysis
   MLIRSideEffectInterfaces
index 16258ed..c71caf0 100644 (file)
@@ -60,7 +60,7 @@ add_mlir_library(MLIRJitRunner
   MLIRExecutionEngine
   MLIRIR
   MLIRParser
-  MLIRStandardOps
+  MLIRStandard
   MLIRTargetLLVMIR
   MLIRTransforms
   MLIRStandardToLLVM
index 58c5fa6..8a057e3 100644 (file)
@@ -30,10 +30,10 @@ add_mlir_library(MLIRTransforms
   MLIRTransformsPassIncGen
 
   LINK_LIBS PUBLIC
-  MLIRAffineOps
+  MLIRAffine
   MLIRAnalysis
   MLIRCopyOpInterface
-  MLIRLinalgOps
+  MLIRLinalg
   MLIRLoopLikeInterface
   MLIRSCF
   MLIRPass
index 3fc45a8..9fa59bb 100644 (file)
@@ -14,10 +14,10 @@ add_mlir_library(MLIRTransformUtils
   MLIRStandardOpsIncGen
 
   LINK_LIBS PUBLIC
-  MLIRAffineOps
+  MLIRAffine
   MLIRAnalysis
   MLIRLoopAnalysis
   MLIRSCF
   MLIRPass
-  MLIRStandardOps
+  MLIRStandard
   )
index 96a89d3..5a73c25 100644 (file)
@@ -10,14 +10,14 @@ llvm_update_compile_flags(mlir-edsc-builder-api-test)
 
 target_link_libraries(mlir-edsc-builder-api-test
   PRIVATE
-  MLIRAffineOps
+  MLIRAffine
   MLIRAffineEDSC
   MLIREDSC
   MLIRIR
+  MLIRLinalg
   MLIRLinalgEDSC
-  MLIRLinalgOps
   MLIRSCF
-  MLIRStandardOps
+  MLIRStandard
   MLIRTransforms
   MLIRVector
   )
index b48d464..696b439 100644 (file)
@@ -38,7 +38,7 @@ add_mlir_library(MLIRTestDialect
   MLIRInferTypeOpInterface
   MLIRLinalgTransforms
   MLIRPass
-  MLIRStandardOps
+  MLIRStandard
   MLIRStandardOpsTransforms
   MLIRTransformUtils
   MLIRTransforms
index 5bf6062..6aaedf1 100644 (file)
@@ -39,12 +39,12 @@ add_mlir_library(MLIRTestTransforms
   MLIRStandardOpsIncGen
 
   LINK_LIBS PUBLIC
-  MLIRAffineOps
+  MLIRAffine
   MLIRAnalysis
   MLIREDSC
   MLIRGPU
   MLIRGPUToGPURuntimeTransforms
-  MLIRLinalgOps
+  MLIRLinalg
   MLIRLinalgTransforms
   MLIRNVVMIR
   MLIRSCF