Avoiding copy by passing param by reference

It is best to pass bad_value_ param by reference to avoid copy.

diff --git a/modules/core/src/system.cpp b/modules/core/src/system.cpp
index d0412a36e5aff88f5f5099fd7331487512418f8c..6e882e1ddec8b26a07ba56ceae06fc2ea708c8f0 100644 (file)
--- a/modules/core/src/system.cpp
+++ b/modules/core/src/system.cpp
@@ -1938,7 +1938,7 @@ class ParseError
 {
     std::string bad_value;
 public:
-    ParseError(const std::string bad_value_) :bad_value(bad_value_) {}
+    ParseError(const std::string &bad_value_) :bad_value(bad_value_) {}
     std::string toString(const std::string &param) const
     {
         std::ostringstream out;