dpaa2-eth: drop double zeroing
authorJulia Lawall <Julia.Lawall@inria.fr>
Sun, 20 Sep 2020 11:26:15 +0000 (13:26 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 21 Sep 2020 02:09:11 +0000 (19:09 -0700)
sg_init_table zeroes its first argument, so the allocation of that argument
doesn't have to.

the semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,n,flags;
@@

x =
- kcalloc
+ kmalloc_array
  (n,sizeof(struct scatterlist),flags)
...
sg_init_table(x,n)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c

index b6cdf84..5bc9651 100644 (file)
@@ -697,7 +697,7 @@ static int dpaa2_eth_build_sg_fd(struct dpaa2_eth_priv *priv,
        if (unlikely(PAGE_SIZE / sizeof(struct scatterlist) < nr_frags + 1))
                return -EINVAL;
 
-       scl = kcalloc(nr_frags + 1, sizeof(struct scatterlist), GFP_ATOMIC);
+       scl = kmalloc_array(nr_frags + 1, sizeof(struct scatterlist), GFP_ATOMIC);
        if (unlikely(!scl))
                return -ENOMEM;