soc: ti: knav_qmss_queue: Use IS_ERR instead of IS_ERR_OR_NULL when checking knav_que...
authorHaowen Bai <baihaowen@meizu.com>
Sun, 24 Apr 2022 02:05:43 +0000 (10:05 +0800)
committerNishanth Menon <nm@ti.com>
Tue, 3 May 2022 13:02:05 +0000 (08:02 -0500)
As the usage of knav_queue_open():

* Returns a handle to the open hardware queue if successful. Use IS_ERR()
* to check the returned value for error codes.

It will only return error codes, not null.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Link: https://lore.kernel.org/r/1650765944-20170-1-git-send-email-baihaowen@meizu.com
drivers/soc/ti/knav_qmss_queue.c

index 30612719e2f1da7ac638789e6142ef2e2f7ccc9f..92af7d1b6f5bd371e574b1629621b7dcfe4c1727 100644 (file)
@@ -789,7 +789,7 @@ void *knav_pool_create(const char *name,
        }
 
        pool->queue = knav_queue_open(name, KNAV_QUEUE_GP, 0);
-       if (IS_ERR_OR_NULL(pool->queue)) {
+       if (IS_ERR(pool->queue)) {
                dev_err(kdev->dev,
                        "failed to open queue for pool(%s), error %ld\n",
                        name, PTR_ERR(pool->queue));