phy: ti: tusb1210: Don't check for write errors when powering on
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 13 Jun 2022 16:08:48 +0000 (19:08 +0300)
committerVinod Koul <vkoul@kernel.org>
Tue, 5 Jul 2022 05:27:32 +0000 (10:57 +0530)
On some platforms, like Intel Merrifield, the writing values during power on
may timeout:

   tusb1210 dwc3.0.auto.ulpi: error -110 writing val 0x41 to reg 0x80
   phy phy-dwc3.0.auto.ulpi.0: phy poweron failed --> -110
   dwc3 dwc3.0.auto: error -ETIMEDOUT: failed to initialize core
   dwc3: probe of dwc3.0.auto failed with error -110

which effectively fails the probe of the USB controller.
Drop the check as it was before the culprit commit (see Fixes tag).

Fixes: 09a3512681b3 ("phy: ti: tusb1210: Improve ulpi_read()/_write() error checking")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: Ferry Toth <fntoth@gmail.com>
Link: https://lore.kernel.org/r/20220613160848.82746-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/ti/phy-tusb1210.c

index c3ab4b6..669c13d 100644 (file)
@@ -105,8 +105,9 @@ static int tusb1210_power_on(struct phy *phy)
        msleep(TUSB1210_RESET_TIME_MS);
 
        /* Restore the optional eye diagram optimization value */
-       return tusb1210_ulpi_write(tusb, TUSB1210_VENDOR_SPECIFIC2,
-                                  tusb->vendor_specific2);
+       tusb1210_ulpi_write(tusb, TUSB1210_VENDOR_SPECIFIC2, tusb->vendor_specific2);
+
+       return 0;
 }
 
 static int tusb1210_power_off(struct phy *phy)