media: saa7164: Fix driver name in debug output
authorBrad Love <brad@nextdimension.cc>
Fri, 4 May 2018 21:53:35 +0000 (17:53 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Aug 2018 05:50:35 +0000 (07:50 +0200)
[ Upstream commit 0cc4655cb57af0b7e105d075c4f83f8046efafe7 ]

This issue was reported by a user who downloaded a corrupt saa7164
firmware, then went looking for a valid xc5000 firmware to fix the
error displayed...but the device in question has no xc5000, thus after
much effort, the wild goose chase eventually led to a support call.

The xc5000 has nothing to do with saa7164 (as far as I can tell),
so replace the string with saa7164 as well as give a meaningful
hint on the firmware mismatch.

Signed-off-by: Brad Love <brad@nextdimension.cc>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/pci/saa7164/saa7164-fw.c

index ef49064..a504618 100644 (file)
@@ -426,7 +426,8 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev)
                        __func__, fw->size);
 
                if (fw->size != fwlength) {
-                       printk(KERN_ERR "xc5000: firmware incorrect size\n");
+                       printk(KERN_ERR "saa7164: firmware incorrect size %zu != %u\n",
+                               fw->size, fwlength);
                        ret = -ENOMEM;
                        goto out;
                }