soc: qcom: rpmhpd: Allow RPMHPD driver to be loaded as a module
authorJohn Stultz <john.stultz@linaro.org>
Thu, 26 Mar 2020 22:44:59 +0000 (22:44 +0000)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 14 Apr 2020 22:39:46 +0000 (15:39 -0700)
This patch allow the rpmhpd driver to be loaded as a permenent
module. Meaning it can be loaded from a module, but then cannot
be unloaded.

Ideally, it would include a remove hook and related logic, but
apparently the genpd code isn't able to track usage and cleaning
things up?

So making it a permenent module at least improves things slightly
over requiring it to be a built in driver.

Cc: Todd Kjos <tkjos@google.com>
Cc: Saravana Kannan <saravanak@google.com>
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rajendra Nayak <rnayak@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org
Acked-by: Saravana Kannan <saravanak@google.com>
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Link: https://lore.kernel.org/r/20200326224459.105170-4-john.stultz@linaro.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/soc/qcom/Kconfig
drivers/soc/qcom/rpmhpd.c

index 70d97147d87e24c87c910976fb76140eabda6b66..c2a8fcdb24b97fb80e7272e17e80c1eb71d292c9 100644 (file)
@@ -117,7 +117,7 @@ config QCOM_RPMH
          help apply the aggregated state on the resource.
 
 config QCOM_RPMHPD
-       bool "Qualcomm RPMh Power domain driver"
+       tristate "Qualcomm RPMh Power domain driver"
        depends on QCOM_RPMH && QCOM_COMMAND_DB
        help
          QCOM RPMh Power domain driver to support power-domains with
index 4d264d0672c4fb627f722bc2497283344f299299..0bb12d5870a778f63f0530c9d7c4f081101a1959 100644 (file)
@@ -4,6 +4,7 @@
 #include <linux/err.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
+#include <linux/module.h>
 #include <linux/mutex.h>
 #include <linux/pm_domain.h>
 #include <linux/slab.h>
@@ -189,6 +190,7 @@ static const struct of_device_id rpmhpd_match_table[] = {
        { .compatible = "qcom,sm8150-rpmhpd", .data = &sm8150_desc },
        { }
 };
+MODULE_DEVICE_TABLE(of, rpmhpd_match_table);
 
 static int rpmhpd_send_corner(struct rpmhpd *pd, int state,
                              unsigned int corner, bool sync)
@@ -460,3 +462,6 @@ static int __init rpmhpd_init(void)
        return platform_driver_register(&rpmhpd_driver);
 }
 core_initcall(rpmhpd_init);
+
+MODULE_DESCRIPTION("Qualcomm Technologies, Inc. RPMh Power Domain Driver");
+MODULE_LICENSE("GPL v2");