of: Warn if of_graph_parse_endpoint is called with the root node
authorPhilipp Zabel <p.zabel@pengutronix.de>
Tue, 4 Mar 2014 11:31:24 +0000 (12:31 +0100)
committerPhilipp Zabel <p.zabel@pengutronix.de>
Thu, 6 Mar 2014 16:41:54 +0000 (17:41 +0100)
If of_graph_parse_endpoint is given a parentless node instead of an
endpoint node, it is clearly a bug.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Acked-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
drivers/of/base.c

index 715144a..fd4b9c2 100644 (file)
@@ -1996,6 +1996,9 @@ int of_graph_parse_endpoint(const struct device_node *node,
 {
        struct device_node *port_node = of_get_parent(node);
 
+       WARN_ONCE(!port_node, "%s(): endpoint %s has no parent node\n",
+                 __func__, node->full_name);
+
        memset(endpoint, 0, sizeof(*endpoint));
 
        endpoint->local_node = node;