net/mlx5: Remove "recovery" arg from mlx5_load_one() function
authorJiri Pirko <jiri@nvidia.com>
Thu, 26 Jan 2023 12:23:17 +0000 (13:23 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 May 2023 14:03:25 +0000 (23:03 +0900)
[ Upstream commit 5977ac3910f1cbaf44dca48179118b25c206ac29 ]

mlx5_load_one() is always called with recovery==false, so remove the
unneeded function arg.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Stable-dep-of: dfad99750c0f ("net/mlx5: Use recovery timeout on sync reset flow")
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c
drivers/net/ethernet/mellanox/mlx5/core/main.c
drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h

index 1e46f9afa40e0fd2370a700ae3b73dc45d28660b..a1f460c9d3cde6f2c9b31389bea81888427da327 100644 (file)
@@ -154,7 +154,7 @@ static void mlx5_fw_reset_complete_reload(struct mlx5_core_dev *dev)
                if (mlx5_health_wait_pci_up(dev))
                        mlx5_core_err(dev, "reset reload flow aborted, PCI reads still not working\n");
                else
-                       mlx5_load_one(dev, false);
+                       mlx5_load_one(dev);
                devlink_remote_reload_actions_performed(priv_to_devlink(dev), 0,
                                                        BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT) |
                                                        BIT(DEVLINK_RELOAD_ACTION_FW_ACTIVATE));
index 59914f66857da7cb5fa802bb9fdcb02f91e71784..31841f4307feea9edc3372399458f788b613b6c1 100644 (file)
@@ -1484,13 +1484,13 @@ out:
        return err;
 }
 
-int mlx5_load_one(struct mlx5_core_dev *dev, bool recovery)
+int mlx5_load_one(struct mlx5_core_dev *dev)
 {
        struct devlink *devlink = priv_to_devlink(dev);
        int ret;
 
        devl_lock(devlink);
-       ret = mlx5_load_one_devl_locked(dev, recovery);
+       ret = mlx5_load_one_devl_locked(dev, false);
        devl_unlock(devlink);
        return ret;
 }
@@ -1875,8 +1875,7 @@ static void mlx5_pci_resume(struct pci_dev *pdev)
 
        mlx5_pci_trace(dev, "Enter, loading driver..\n");
 
-       err = mlx5_load_one(dev, false);
-
+       err = mlx5_load_one(dev);
        if (!err)
                devlink_health_reporter_state_update(dev->priv.health.fw_fatal_reporter,
                                                     DEVLINK_HEALTH_REPORTER_STATE_HEALTHY);
@@ -1967,7 +1966,7 @@ static int mlx5_resume(struct pci_dev *pdev)
 {
        struct mlx5_core_dev *dev = pci_get_drvdata(pdev);
 
-       return mlx5_load_one(dev, false);
+       return mlx5_load_one(dev);
 }
 
 static const struct pci_device_id mlx5_core_pci_table[] = {
index a806e3de7b7c321ddb17861951e91d47c92bd881..c57e0fc4bab1f15bbfaacf9ae460b9f2e7ba4532 100644 (file)
@@ -321,7 +321,7 @@ int mlx5_init_one(struct mlx5_core_dev *dev);
 void mlx5_uninit_one(struct mlx5_core_dev *dev);
 void mlx5_unload_one(struct mlx5_core_dev *dev);
 void mlx5_unload_one_devl_locked(struct mlx5_core_dev *dev);
-int mlx5_load_one(struct mlx5_core_dev *dev, bool recovery);
+int mlx5_load_one(struct mlx5_core_dev *dev);
 int mlx5_load_one_devl_locked(struct mlx5_core_dev *dev, bool recovery);
 
 int mlx5_vport_get_other_func_cap(struct mlx5_core_dev *dev, u16 function_id, void *out);