power: rpi-poe: Drop CURRENT_AVG as it is not hardware averaged
authorDave Stevenson <dave.stevenson@raspberrypi.com>
Thu, 20 Jan 2022 15:48:03 +0000 (15:48 +0000)
committerDom Cobley <popcornmix@gmail.com>
Mon, 21 Mar 2022 16:04:38 +0000 (16:04 +0000)
As documented the _AVG parameters are meant to be hardware
averaged, but the implementation for the PoE+ HAT was done in
software in the firmware.

Drop the property.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
drivers/power/supply/rpi_poe_power.c

index 0c96b2c..7cf1014 100644 (file)
@@ -106,15 +106,6 @@ static int rpi_poe_power_supply_get_property(struct power_supply *psy,
                r_val->intval = (val > 5);
                return 0;
 
-       case POWER_SUPPLY_PROP_CURRENT_AVG:
-               val = 50;
-               ret = read_reg(ctx->fw, RPI_POE_ADC_REG, &val);
-               if (ret)
-                       return ret;
-               val = (val * 3300)/9821;
-               r_val->intval = val * 1000;
-               return 0;
-
        case POWER_SUPPLY_PROP_CURRENT_NOW:
                ret = read_reg(ctx->fw, RPI_POE_ADC_REG, &val);
                if (ret)
@@ -145,7 +136,6 @@ static int rpi_poe_power_supply_get_property(struct power_supply *psy,
 static enum power_supply_property rpi_poe_power_supply_properties[] = {
        POWER_SUPPLY_PROP_HEALTH,
        POWER_SUPPLY_PROP_ONLINE,
-       POWER_SUPPLY_PROP_CURRENT_AVG,
        POWER_SUPPLY_PROP_CURRENT_NOW,
        POWER_SUPPLY_PROP_CURRENT_MAX,
 };