plugins/elements/gstqueue.c: The queue was posting a non-needed GST_MESSAGE_ERROR...

Original commit message from CVS:
* plugins/elements/gstqueue.c: (gst_queue_push_one):
The queue was posting a non-needed GST_MESSAGE_ERROR when pushing a
buffer returned a fatal error. It should just send an EOS and stop
it's task.
Upstream elements will then properly receive the GST_FLOW_UNEXPECTED
when pushing buffers on the queue and will be able to handle the event.

diff --git a/ChangeLog b/ChangeLog
index 829dc16..3e6a4b9 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2006-05-16  Edward Hervey  <edward@fluendo.com>
+
+       * plugins/elements/gstqueue.c: (gst_queue_push_one):
+       The queue was posting a non-needed GST_MESSAGE_ERROR when pushing a
+       buffer returned a fatal error. It should just send an EOS and stop
+       it's task.
+       Upstream elements will then properly receive the GST_FLOW_UNEXPECTED
+       when pushing buffers on the queue and will be able to handle the event.
+
 2006-05-16  Tim-Philipp Müller  <tim at centricular dot net>
 
        * docs/manual/basics-bins.xml:

diff --git a/plugins/elements/gstqueue.c b/plugins/elements/gstqueue.c
index f7e7d13..9606699 100644 (file)
--- a/plugins/elements/gstqueue.c
+++ b/plugins/elements/gstqueue.c
@@ -777,12 +777,9 @@ gst_queue_push_one (GstQueue * queue)
       flowname = gst_flow_get_name (result);
 
       queue->srcresult = result;
-      if (GST_FLOW_IS_FATAL (result)) {
-        GST_ELEMENT_ERROR (queue, STREAM, FAILED,
-            (_("Internal data flow error.")),
-            ("streaming stopped, reason %s", flowname));
+      if (GST_FLOW_IS_FATAL (result))
         gst_pad_push_event (queue->srcpad, gst_event_new_eos ());
-      }
+
       GST_DEBUG_OBJECT (queue, "pausing queue, reason %s", flowname);
       gst_pad_pause_task (queue->srcpad);
     }