intel-rst: Use ACPI_FAILURE() macro instead !ACPI_SUCCESS() for error checking
authorPeter Ujfalusi <peter.ujfalusi@gmail.com>
Tue, 16 Sep 2014 21:13:55 +0000 (00:13 +0300)
committerDarren Hart <dvhart@linux.intel.com>
Wed, 17 Sep 2014 20:55:53 +0000 (13:55 -0700)
ACPI_SUCCESS is defined as:
#define ACPI_SUCCESS(a) (!(a))

There is no need for the the double ! since there is already a macro
defined for failures: ACPI_FAILURE()

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
drivers/platform/x86/intel-rst.c

index d45bca3..8c6a8fe 100644 (file)
@@ -35,7 +35,7 @@ static ssize_t irst_show_wakeup_events(struct device *dev,
        acpi = to_acpi_device(dev);
 
        status = acpi_evaluate_integer(acpi->handle, "GFFS", NULL, &value);
-       if (!ACPI_SUCCESS(status))
+       if (ACPI_FAILURE(status))
                return -EINVAL;
 
        return sprintf(buf, "%lld\n", value);
@@ -59,7 +59,7 @@ static ssize_t irst_store_wakeup_events(struct device *dev,
 
        status = acpi_execute_simple_method(acpi->handle, "SFFS", value);
 
-       if (!ACPI_SUCCESS(status))
+       if (ACPI_FAILURE(status))
                return -EINVAL;
 
        return count;
@@ -81,7 +81,7 @@ static ssize_t irst_show_wakeup_time(struct device *dev,
        acpi = to_acpi_device(dev);
 
        status = acpi_evaluate_integer(acpi->handle, "GFTV", NULL, &value);
-       if (!ACPI_SUCCESS(status))
+       if (ACPI_FAILURE(status))
                return -EINVAL;
 
        return sprintf(buf, "%lld\n", value);
@@ -105,7 +105,7 @@ static ssize_t irst_store_wakeup_time(struct device *dev,
 
        status = acpi_execute_simple_method(acpi->handle, "SFTV", value);
 
-       if (!ACPI_SUCCESS(status))
+       if (ACPI_FAILURE(status))
                return -EINVAL;
 
        return count;