usb: host: fhci-tds: Remove unused variables 'buf' and 'extra_data'
authorLee Jones <lee.jones@linaro.org>
Mon, 6 Jul 2020 13:33:39 +0000 (14:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jul 2020 15:19:59 +0000 (17:19 +0200)
Neither have been used since the driver's inception in 2009.

Fixes the following W=1 kernel build warning(s):

 drivers/usb/host/fhci-tds.c: In function ‘fhci_flush_bds’:
 drivers/usb/host/fhci-tds.c:472:6: warning: variable ‘buf’ set but not used [-Wunused-but-set-variable]
 472 | u32 buf;
 | ^~~
 drivers/usb/host/fhci-tds.c:470:6: warning: variable ‘extra_data’ set but not used [-Wunused-but-set-variable]
 470 | u16 extra_data;
 | ^~~~~~~~~~
 drivers/usb/host/fhci-tds.c: In function ‘fhci_flush_actual_frame’:
 drivers/usb/host/fhci-tds.c:527:6: warning: variable ‘extra_data’ set but not used [-Wunused-but-set-variable]
 527 | u16 extra_data;
 | ^~~~~~~~~~

Cc: Shlomi Gridish <gridish@freescale.com>
Cc: Jerry Huang <Chang-Ming.Huang@freescale.com>
Cc: Peter Barada <peterb@logicpd.com>
Cc: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20200706133341.476881-31-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/fhci-tds.c

index f3308ce..d98fd9e 100644 (file)
@@ -467,17 +467,15 @@ u32 fhci_host_transaction(struct fhci_usb *usb,
 /* Reset the Tx BD ring */
 void fhci_flush_bds(struct fhci_usb *usb)
 {
-       u16 extra_data;
        u16 td_status;
-       u32 buf;
        struct usb_td __iomem *td;
        struct endpoint *ep = usb->ep0;
 
        td = ep->td_base;
        while (1) {
                td_status = in_be16(&td->status);
-               buf = in_be32(&td->buf_ptr);
-               extra_data = in_be16(&td->extra);
+               in_be32(&td->buf_ptr);
+               in_be16(&td->extra);
 
                /* if the TD is not empty - we'll confirm it as Timeout */
                if (td_status & TD_R)
@@ -524,7 +522,6 @@ void fhci_flush_actual_frame(struct fhci_usb *usb)
 {
        u8 mode;
        u16 tb_ptr;
-       u16 extra_data;
        u16 td_status;
        u32 buf_ptr;
        struct usb_td __iomem *td;
@@ -538,7 +535,7 @@ void fhci_flush_actual_frame(struct fhci_usb *usb)
        td = cpm_muram_addr(tb_ptr);
        td_status = in_be16(&td->status);
        buf_ptr = in_be32(&td->buf_ptr);
-       extra_data = in_be16(&td->extra);
+       in_be16(&td->extra);
        do {
                if (td_status & TD_R) {
                        out_be16(&td->status, (td_status & ~TD_R) | TD_TO);
@@ -552,7 +549,7 @@ void fhci_flush_actual_frame(struct fhci_usb *usb)
                td = next_bd(ep->td_base, td, td_status);
                td_status = in_be16(&td->status);
                buf_ptr = in_be32(&td->buf_ptr);
-               extra_data = in_be16(&td->extra);
+               in_be16(&td->extra);
        } while ((td_status & TD_R) || buf_ptr);
 
        fhci_td_transaction_confirm(usb);