Revert "media: bcm2835-codec: Limit video callbacks"
authorDom Cobley <popcornmix@gmail.com>
Thu, 16 Dec 2021 14:22:37 +0000 (14:22 +0000)
committerPhil Elwell <8911409+pelwell@users.noreply.github.com>
Thu, 16 Dec 2021 14:43:37 +0000 (14:43 +0000)
This reverts commit f814bfc5f4d3005eb266a1556be8b7b8770629bd.

The commit caused media stalls with kodi and stateful
v4l2 video decode.

John is now using a different way of limiting latency
through stateful v4l2 so this is not required.

drivers/staging/vc04_services/bcm2835-codec/bcm2835-v4l2-codec.c

index 4cd9402..fdbaa96 100644 (file)
@@ -2536,14 +2536,6 @@ static int bcm2835_codec_create_component(struct bcm2835_codec_ctx *ctx)
                                              MMAL_PARAMETER_VIDEO_STOP_ON_PAR_COLOUR_CHANGE,
                                              &enable,
                                              sizeof(enable));
-
-               enable = (unsigned int)-5;
-               vchiq_mmal_port_parameter_set(dev->instance,
-                                             &ctx->component->control,
-                                             MMAL_PARAMETER_VIDEO_MAX_NUM_CALLBACKS,
-                                             &enable,
-                                             sizeof(enable));
-
        } else if (dev->role == DEINTERLACE) {
                /* Select the default deinterlace algorithm. */
                int half_framerate = 0;