ASoC: eukrea-tlv320: Fix of_node_put() call with uninitialized object
authorTakashi Iwai <tiwai@suse.de>
Tue, 7 Oct 2014 18:56:29 +0000 (20:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 16 Jan 2015 14:59:45 +0000 (06:59 -0800)
commit 077661b6ed24e530dabc9db3ab3ae48fbaf19679 upstream.

The of_node_put() call in eukrea_tlv320_probe() may take an
uninitialized pointer, as compiler spotted out:
  sound/soc/fsl/eukrea-tlv320.c:221:14: warning: 'ssi_np' may be used uninitialized in this function [-Wuninitialized]

This patch adds the proper NULL initializations as a fix.
(codec_np is also NULL initialized just for consistency.)

Fixes: 66f232908de2 ('ASoC: eukrea-tlv320: Add DT support')
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/fsl/eukrea-tlv320.c

index eb093d5b85c4cce3f0bf10616aeb1fcc61f859e9..54790461f39e85cf650a8291bbed36fadef34218 100644 (file)
@@ -105,7 +105,7 @@ static int eukrea_tlv320_probe(struct platform_device *pdev)
        int ret;
        int int_port = 0, ext_port;
        struct device_node *np = pdev->dev.of_node;
-       struct device_node *ssi_np, *codec_np;
+       struct device_node *ssi_np = NULL, *codec_np = NULL;
 
        eukrea_tlv320.dev = &pdev->dev;
        if (np) {